From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH] ALSA: HDA: Use LPIB position fix for
	Macbook Pro 7, 1
Date: Fri, 13 Jan 2012 10:01:05 +0100
Message-ID: <s5hlipcht7y.wl%tiwai@suse.de>
References: <1326382274-4103-1-git-send-email-david.henningsson@canonical.com>
	<s5hobu8htp9.wl%tiwai@suse.de> <4F0FF19C.10304@canonical.com>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15])
	by alsa0.perex.cz (Postfix) with ESMTP id E449D24479
	for <alsa-devel@alsa-project.org>; Fri, 13 Jan 2012 10:01:05 +0100 (CET)
In-Reply-To: <4F0FF19C.10304@canonical.com>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Sender: alsa-devel-bounces@alsa-project.org
Errors-To: alsa-devel-bounces@alsa-project.org
To: David Henningsson <david.henningsson@canonical.com>
Cc: alsa-devel@alsa-project.org
List-Id: alsa-devel@alsa-project.org

At Fri, 13 Jan 2012 09:55:56 +0100,
David Henningsson wrote:
> 
> On 2012-01-13 09:50, Takashi Iwai wrote:
> > At Thu, 12 Jan 2012 16:31:14 +0100,
> > David Henningsson wrote:
> >>
> >> Several users have reported "choppy" audio under the 3.2 kernel,
> >> and that changing position_fix to 1 has resolved their problem.
> >> The chip is an nVidia Corporation MCP89 High Definition Audio,
> >> [10de:0d94] (rev a2).
> >>
> >> Cc: stable@kernel.org (v3.2+)
> >> BugLink: https://bugs.launchpad.net/bugs/909419
> >> Signed-off-by: David Henningsson<david.henningsson@canonical.com>
> >
> > Applied now.  Thanks.
> 
> Thanks.
> 
> Just a thought...this was reported as working better under the previous 
> Ubuntu release, which run kernel 3.0 (and not too many changes in 
> PulseAudio), i e, a regression. While I haven't done any serious kernel 
> bisection of this, I know you've being doing some work with the 
> snoop/non-snoop stuff lately, which I haven't followed closely. Do you 
> think this can be related to why we're seeing broken position values 
> when we're using the DMA position buffer map on some machines?

Honestly I have no idea.  The possibility can't be excluded, though,
since Windows seems using the non-cached pages as default.

The position-buffer is used primarily just because this was more
robust on old hardware.  OTOH, LPIB seems more robust on modern chips,
so we may think of switching to LPIB, too.


Takashi