From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: Fixes and misc improvements for alsa-lib,
	alsa-plugins, alsa-utils
Date: Fri, 21 Nov 2008 12:52:45 +0100
Message-ID: <s5hljvd8fea.wl%tiwai@suse.de>
References: <m2ej15okqv.fsf@gmail.com>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from mx2.suse.de (mx2.suse.de [195.135.220.15])
	by alsa0.perex.cz (Postfix) with ESMTP id 35DCD2446D
	for <alsa-devel@alsa-project.org>; Fri, 21 Nov 2008 12:52:46 +0100 (CET)
In-Reply-To: <m2ej15okqv.fsf@gmail.com>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Sender: alsa-devel-bounces@alsa-project.org
Errors-To: alsa-devel-bounces@alsa-project.org
To: "Diego E. 'Flameeyes' =?ISO-8859-1?Q?Petten=F2?=" <flameeyes@gmail.com>
Cc: alsa-devel@alsa-project.org
List-Id: alsa-devel@alsa-project.org

At Fri, 21 Nov 2008 03:50:32 +0100,
Diego E. 'Flameeyes' Petten=F2 wrote:
> =

> I've taken some time to fix some autotools nitpicks and some generic
> optimisations, I hope they can be useful:
> =

> git://git.flameeyes.eu/others/alsa/alsa-lib.git flameeyes
> =

> Diego E. 'Flameeyes' Petten=F2 (5):
>       Don't use AC_CANONICAL_SYSTEM, only use AC_CANONICAL_HOST.
>       Add the attributes.m4 macro file from xine/lscube.
>       Check for --no-undefined linker flag and use it.
>       Make sure that python libraries are passed through LIBADD.
>       Make some static tables and strings constants.

These changes look OK, but could you add your sign-off to each commit?

> git://git.flameeyes.eu/others/alsa/alsa-plugins.git flameeyes
> =

> Diego E. 'Flameeyes' Petten=F2 (6):
>       Add the attributes.m4 macro file from xine/lscube.
>       Check for --no-undefined linker flag and use it.
>       Cleanup flags in maemo/Makefile.am
>       [RFC] Don't use pow() for calculating a power of 2, use shift inste=
ad.
>       Make some static tables and strings constants.
>       Mark as static the functions not used outside their unit.

Ditto.

> git://git.flameeyes.eu/others/alsa/alsa-utils.git flameeyes
> =

> Diego E. 'Flameeyes' Petten=F2 (4):
>       Remove some dead code (comparisons between 0 and unsigned integers).

The change in alsactl/state.c gives wrong indentations.
Please fix.

>       Remove some unused variables.
>       Mark static the functions not used outside their unit.
>       Make some static tables and strings constants.

Give your sign-off, please, too.


thanks,

Takashi