From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262791AbUDAJQ5 (ORCPT ); Thu, 1 Apr 2004 04:16:57 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262815AbUDAJQ5 (ORCPT ); Thu, 1 Apr 2004 04:16:57 -0500 Received: from ns.suse.de ([195.135.220.2]:35001 "EHLO Cantor.suse.de") by vger.kernel.org with ESMTP id S262791AbUDAJQz (ORCPT ); Thu, 1 Apr 2004 04:16:55 -0500 Date: Thu, 01 Apr 2004 11:15:23 +0200 Message-ID: From: Takashi Iwai To: Pavel Machek Cc: perex@suse.cz, Tjeerd.Mulder@fujitsu-siemens.com, kernel list Subject: Re: via82xx cmd line parsing is evil [was Re: Sound on newer arima notebook...] In-Reply-To: <20040401090452.GF224@elf.ucw.cz> References: <20040331145206.GA384@elf.ucw.cz> <20040401080954.GA464@elf.ucw.cz> <20040401082905.GE224@elf.ucw.cz> <20040401090452.GF224@elf.ucw.cz> User-Agent: Wanderlust/2.10.1 (Watching The Wheels) SEMI/1.14.5 (Awara-Onsen) FLIM/1.14.5 (Demachiyanagi) APEL/10.6 MULE XEmacs/21.4 (patch 13) (Rational FORTRAN) (i386-suse-linux) MIME-Version: 1.0 (generated by SEMI 1.14.5 - "Awara-Onsen") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org At Thu, 1 Apr 2004 11:04:52 +0200, Pavel Machek wrote: > > Hi! > > > > > snd-via82xx=enable:1 syntax is ugly, too, and we have better syntax > > > already. via82xx.enable=1 via82xx.ac97_quirk=2 should be possible with > > > new param handling code. > > > > oh that's good to know. > > And here's a patch. It compiles. heh, we're crossfiring :) > @@ -82,33 +81,36 @@ > static int joystick[SNDRV_CARDS]; > #endif > static int ac97_clock[SNDRV_CARDS] = {[0 ... (SNDRV_CARDS - 1)] = 48000}; > -static int ac97_quirk[SNDRV_CARDS] = {[0 ... (SNDRV_CARDS - 1)] = AC97_TUNE_DEFAULT}; > -static int dxs_support[SNDRV_CARDS]; > +static int ac97_quirk[SNDRV_CARDS] = {[0 ... (SNDRV_CARDS - 1)] = 1}; > +static int dxs_support[SNDRV_CARDS] = {[0 ... (SNDRV_CARDS - 1)] = 1}; i suppose that ac97_quirk=1 and dxs_support=1 work fine with your machine? (i don't want to change defaults for all devices yet :) Takashi