Re: [Alsa-user] Upgrade problems -addendum

[Takashi Iwai <tiwai@suse.de>]

[-- Attachment #1: Type: text/plain, Size: 1237 bytes --]

(moved to alsa-devel)

At Wed, 22 Jan 2003 16:47:00 +0100,
Tais M. Hansen <tais.hansen@osd.dk> wrote:
> 
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> On Wednesday 22 January 2003 15:50, Takashi Iwai wrote:
> > > I'm getting a bunch of errors in syslog though. I imagine it's just debug
> > > output and nothing serious.
> > could you enable POINTER_DEBUG at the beginning of via82xx.c?
> > this will print more debug lines.
> > which application cause these messages?  every application?
> > do you notice any drop outs during playback?
> 
> I've enabled POINTER_DEBUG and logged ALSA & fail output from syslog. The 
> output is attached in two files. (gzipped)
> 
> ogg123:
> I heard a short pop in the sound with each log entry pair; fail & ALSA.
> 
> artsd:
> Log entries only occured when starting/resuming or suspending/killing artsd. 
> Tried playing for a while with noatun and I didn't notice any pops or other 
> anomalies.

could you test the following two patches?
with the first one, the driver will calculate the current pointer like
VIA686 does.  if this is ok, no messages will appear.

the second one is to force to increase the index.  you'll see debug
messages, anyway, if POINTER_DEBUG is defined.


Takashi

[-- Attachment #2: via-pointer-test.dif --]
[-- Type: application/octet-stream, Size: 620 bytes --]

Index: alsa-kernel/pci/via82xx.c
===================================================================
RCS file: /suse/tiwai/cvs/alsa/alsa-kernel/pci/via82xx.c,v
retrieving revision 1.21
diff -u -r1.21 via82xx.c
--- alsa-kernel/pci/via82xx.c	22 Jan 2003 14:21:05 -0000	1.21
+++ alsa-kernel/pci/via82xx.c	22 Jan 2003 16:15:33 -0000
@@ -1037,7 +1037,8 @@
 	.hw_free =	snd_via82xx_hw_free,
 	.prepare =	snd_via8233_multi_prepare,
 	.trigger =	snd_via82xx_pcm_trigger,
-	.pointer =	snd_via8233_pcm_pointer,
+	// .pointer =	snd_via8233_pcm_pointer,
+	.pointer =	snd_via686_pcm_pointer,
 	.page =		snd_pcm_sgbuf_ops_page,
 };
 

[-- Attachment #3: via-pointer-test2.dif --]
[-- Type: application/octet-stream, Size: 1196 bytes --]

Index: alsa-kernel/pci/via82xx.c
===================================================================
RCS file: /suse/tiwai/cvs/alsa/alsa-kernel/pci/via82xx.c,v
retrieving revision 1.21
diff -u -r1.21 via82xx.c
--- alsa-kernel/pci/via82xx.c	22 Jan 2003 14:21:05 -0000	1.21
+++ alsa-kernel/pci/via82xx.c	22 Jan 2003 16:20:04 -0000
@@ -589,8 +589,16 @@
 #endif
 		/* count register returns full size when end of buffer is reached */
 		if (size != count) {
+#if 0
 			snd_printd(KERN_ERR "invalid via82xx_cur_ptr, using last valid pointer\n");
 			res = viadev->lastpos;
+#else
+			idx++;
+			if (idx >= viadev->tbl_entries)
+				idx = 0;
+			size = viadev->idx_table[idx].size;
+			res = viadev->idx_table[idx].offset + size - count;
+#endif
 		} else {
 			res = viadev->idx_table[idx].offset + size;
 			if (res < viadev->lastpos && (res >= viadev->bufsize2 || viadev->lastpos < viadev->bufsize2)) {
@@ -648,7 +656,7 @@
 		return 0;
 	spin_lock(&chip->reg_lock);
 	count = inl(VIAREG(chip, OFFSET_CURR_COUNT) + viadev->reg_offset);
-	idx = count >> 24;
+	idx = (count >> 24) & viadev->tbl_entries;
 	count &= 0xffffff;
 	res = calc_linear_pos(viadev, idx, count);
 	spin_unlock(&chip->reg_lock);