From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [GIT PULL] sound updates for 4.15-rc1 Date: Wed, 15 Nov 2017 08:34:09 +0100 Message-ID: References: Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 35FAC267544 for ; Wed, 15 Nov 2017 08:34:09 +0100 (CET) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Linus Torvalds Cc: alsa-devel@alsa-project.org, Vinod Koul , Pierre-Louis Bossart , Linux Kernel Mailing List , Liam Girdwood , Mark Brown List-Id: alsa-devel@alsa-project.org [Adding more people and alsa-devel to Cc] On Wed, 15 Nov 2017 03:40:09 +0100, Linus Torvalds wrote: > > On Tue, Nov 14, 2017 at 6:51 AM, Takashi Iwai wrote: > > > > please pull sound updates for v4.15-rc1 from: > > Hmm. Making "oldconfig" on my laptop with this, my > SND_SOC_INTEL_SKYLAKE went away. > > And the reason seems to be that new SND_SOC_INTEL_SST_TOPLEVEL config option. > > Which has no help associated with it. > > This is not a friendly thing to do to people. It basically breaks > existing setups for no documented reason, and with no explanation. > > Please fix the config situation. At the very least, add documentation. Sorry about that. I saw Vinod already submitted a patch to add the help text to CONFIG_SND_SOC_INTEL_SST_TOPLEVEL, so the least fix should go in soon. But now looking at these changes, I noticed a few things, too: - With the introduction of SND_SOC_INTEL_SST_TOPLEVEL, keeping SND_SOC_INTEL_COMMON and SND_SOC_INTEL_MACH individually doesn't make much sense. They can be dropped and replaced with SND_SOC_INTEL_SST_TOPLEVEL as a further cleanup. - ... or, make SND_SOC_INTEL_SST_TOPLEVEL=y as default, if this is considered to be a top-level filter config (like the network vendor kconfig items). In that case, the reverse-selection of SND_SOC_INTEL_COMMON and SND_SOC_INTEL_MACH should be avoided, but they should be selected from the actual drivers instead. And I believe there are a few more possible cleanups / fixes in the messy Intel ASoC Kconfigs. For example, SND_SOC_INTEL_SST is almost always set. The only exception is via SND_SST_ATOM_HIFI2_PLATFORM. But all machine drivers using Atom Hifi2 do set SND_SST_IPC_ACPI, which also requires SND_SOC_INTEL_SST. Further looking at this, we see that the only entry that does *not* require SND_SOC_INTEL_SST is the case with SND_MFLD_MACHINE in sound/soc/intel/boards. And now more interesting part -- there is no corresponding entry in Makefile. That is, this kconfig is effectively dead! The source code mfld_machine.c exists, but it's just a place holder now. The code was supposed to be integrated into atom directory by the commit b97169da0699, but it seems forgotten to be updated. Hmm... Takashi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754867AbdKOHeS (ORCPT ); Wed, 15 Nov 2017 02:34:18 -0500 Received: from mx2.suse.de ([195.135.220.15]:57580 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750962AbdKOHeK (ORCPT ); Wed, 15 Nov 2017 02:34:10 -0500 Date: Wed, 15 Nov 2017 08:34:09 +0100 Message-ID: From: Takashi Iwai To: Linus Torvalds Cc: Vinod Koul , Pierre-Louis Bossart , Mark Brown , Liam Girdwood , Linux Kernel Mailing List , alsa-devel@alsa-project.org Subject: Re: [GIT PULL] sound updates for 4.15-rc1 In-Reply-To: References: User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [Adding more people and alsa-devel to Cc] On Wed, 15 Nov 2017 03:40:09 +0100, Linus Torvalds wrote: > > On Tue, Nov 14, 2017 at 6:51 AM, Takashi Iwai wrote: > > > > please pull sound updates for v4.15-rc1 from: > > Hmm. Making "oldconfig" on my laptop with this, my > SND_SOC_INTEL_SKYLAKE went away. > > And the reason seems to be that new SND_SOC_INTEL_SST_TOPLEVEL config option. > > Which has no help associated with it. > > This is not a friendly thing to do to people. It basically breaks > existing setups for no documented reason, and with no explanation. > > Please fix the config situation. At the very least, add documentation. Sorry about that. I saw Vinod already submitted a patch to add the help text to CONFIG_SND_SOC_INTEL_SST_TOPLEVEL, so the least fix should go in soon. But now looking at these changes, I noticed a few things, too: - With the introduction of SND_SOC_INTEL_SST_TOPLEVEL, keeping SND_SOC_INTEL_COMMON and SND_SOC_INTEL_MACH individually doesn't make much sense. They can be dropped and replaced with SND_SOC_INTEL_SST_TOPLEVEL as a further cleanup. - ... or, make SND_SOC_INTEL_SST_TOPLEVEL=y as default, if this is considered to be a top-level filter config (like the network vendor kconfig items). In that case, the reverse-selection of SND_SOC_INTEL_COMMON and SND_SOC_INTEL_MACH should be avoided, but they should be selected from the actual drivers instead. And I believe there are a few more possible cleanups / fixes in the messy Intel ASoC Kconfigs. For example, SND_SOC_INTEL_SST is almost always set. The only exception is via SND_SST_ATOM_HIFI2_PLATFORM. But all machine drivers using Atom Hifi2 do set SND_SST_IPC_ACPI, which also requires SND_SOC_INTEL_SST. Further looking at this, we see that the only entry that does *not* require SND_SOC_INTEL_SST is the case with SND_MFLD_MACHINE in sound/soc/intel/boards. And now more interesting part -- there is no corresponding entry in Makefile. That is, this kconfig is effectively dead! The source code mfld_machine.c exists, but it's just a place holder now. The code was supposed to be integrated into atom directory by the commit b97169da0699, but it seems forgotten to be updated. Hmm... Takashi