From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH v2 5/7] ALSA: hda - Use ops instead of directly accessing chmap helpers Date: Wed, 02 Mar 2016 17:03:10 +0100 Message-ID: References: <1456920208-1172-1-git-send-email-subhransu.s.prusty@intel.com> <1456920208-1172-6-git-send-email-subhransu.s.prusty@intel.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id E000D2654CE for ; Wed, 2 Mar 2016 17:03:10 +0100 (CET) In-Reply-To: <1456920208-1172-6-git-send-email-subhransu.s.prusty@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: "Subhransu S. Prusty" Cc: patches.audio@intel.com, Vinod Koul , alsa-devel@alsa-project.org, broonie@kernel.org, lgirdwood@gmail.com List-Id: alsa-devel@alsa-project.org On Wed, 02 Mar 2016 13:03:26 +0100, Subhransu S. Prusty wrote: > > Added more ops to the chmap object, so most of the helpers can be > accessed through ops instead instead of directly calling them. Too many instead :) > With this moving the chmap helpers to core will be easy. Well, although I asked about reduction of exported stuff, I don't think it's worth to put everything in ops. If any of them would be overridden, it's good to have as an ops. If not, it's fine to have exported symbols. These are just a few entries, not over 20. Takashi