From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH v6 03/15] ASoC: hdac_hdmi: Enable DP1.2 and
	all converters/pins
Date: Tue, 16 Feb 2016 09:16:59 +0100
Message-ID: <s5hmvr183yc.wl-tiwai@suse.de>
References: <1455243375-16067-1-git-send-email-subhransu.s.prusty@intel.com>
 <1455243375-16067-4-git-send-email-subhransu.s.prusty@intel.com>
 <20160215201049.GD18327@sirena.org.uk>
 <s5htwl98v1n.wl-tiwai@suse.de>
 <20160216020026.GI18327@sirena.org.uk>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from mx2.suse.de (mx2.suse.de [195.135.220.15])
 by alsa0.perex.cz (Postfix) with ESMTP id EA72B260686
 for <alsa-devel@alsa-project.org>; Tue, 16 Feb 2016 09:16:59 +0100 (CET)
In-Reply-To: <20160216020026.GI18327@sirena.org.uk>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/options/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel/>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Errors-To: alsa-devel-bounces@alsa-project.org
Sender: alsa-devel-bounces@alsa-project.org
To: Mark Brown <broonie@kernel.org>
Cc: patches.audio@intel.com, Vinod Koul <vinod.koul@intel.com>, alsa-devel@alsa-project.org, "Subhransu S. Prusty" <subhransu.s.prusty@intel.com>, lgirdwood@gmail.com
List-Id: alsa-devel@alsa-project.org

On Tue, 16 Feb 2016 03:00:26 +0100,
Mark Brown wrote:
> 
> On Mon, Feb 15, 2016 at 11:31:48PM +0100, Takashi Iwai wrote:
> > Mark Brown wrote:
> > > On Fri, Feb 12, 2016 at 07:46:03AM +0530, Subhransu S. Prusty wrote:
> 
> > > > +	vendor_param |= INTEL_EN_ALL_PIN_CVTS;
> > > > +	vendor_param = snd_hdac_codec_read(hdac, INTEL_VENDOR_NID, 0,
> > > > +				INTEL_SET_VENDOR_VERB, vendor_param);
> > > > +	if (vendor_param == -1)
> > > > +		return;
> > > > +}
> 
> > > So to enable the pins we do a read?  That seems...  innovative.  :/
> 
> > It's a weird nature of HD-audio verb handling.  While *_write() just
> > sends the verb asynchronously, *_read() sends the verb, does sync and
> > read-back the return value.  But both read and write may handle the
> > same verb.
> 
> The above one seems especially odd, we do the read and then essentially
> ignore the value (the difference in handling is nonexistant).

There is a difference -- it does sync.

I don't know whether the sync is mandatory in this case, though.


Takashi