All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: David Henningsson <david.henningsson@canonical.com>
Cc: 1132562@bugs.launchpad.net, alsa-devel@alsa-project.org
Subject: Re: [PATCH] ALSA: hda - Use LPIB position fix for Acer AO751h
Date: Thu, 28 Feb 2013 08:21:59 +0100	[thread overview]
Message-ID: <s5hmwuonbs8.wl%tiwai@suse.de> (raw)
In-Reply-To: <1362035910-6594-1-git-send-email-david.henningsson@canonical.com>

At Thu, 28 Feb 2013 08:18:30 +0100,
David Henningsson wrote:
> 
> The user reports a regression (choppy audio), and that
> position_fix=1 (or position_fix=4) fixes the issue.
> 
> This is a Poulsbo controller (8086:811b (rev 07)), so might be
> worth checking if other Poulsbo machines suffer from the same bug.
> 
> Cc: stable@vger.kernel.org [v3.7+]
> BugLink: https://bugs.launchpad.net/bugs/1132562
> Signed-off-by: David Henningsson <david.henningsson@canonical.com>

Please check whether the latest sound git tree works as is.
We enabled the LPIB delay counting for Poulsbo there, and it may fix
most cases.


Takashi


> ---
>  sound/pci/hda/hda_intel.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
> index 4cea6bb6..3505f1e 100644
> --- a/sound/pci/hda/hda_intel.c
> +++ b/sound/pci/hda/hda_intel.c
> @@ -3114,6 +3114,7 @@ static bool check_hdmi_disabled(struct pci_dev *pci)
>   * white/black-listing for position_fix
>   */
>  static struct snd_pci_quirk position_fix_list[] = {
> +	SND_PCI_QUIRK(0x1025, 0x0244, "Acer AO751h", POS_FIX_LPIB),
>  	SND_PCI_QUIRK(0x1028, 0x01cc, "Dell D820", POS_FIX_LPIB),
>  	SND_PCI_QUIRK(0x1028, 0x01de, "Dell Precision 390", POS_FIX_LPIB),
>  	SND_PCI_QUIRK(0x103c, 0x306d, "HP dv3", POS_FIX_LPIB),
> -- 
> 1.7.9.5
> 

  reply	other threads:[~2013-02-28  7:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-28  7:18 [PATCH] ALSA: hda - Use LPIB position fix for Acer AO751h David Henningsson
2013-02-28  7:21 ` Takashi Iwai [this message]
2013-02-28  8:49   ` David Henningsson
2013-02-28  9:29     ` Takashi Iwai
2013-02-28 10:05       ` David Henningsson
2013-02-28 11:52         ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hmwuonbs8.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=1132562@bugs.launchpad.net \
    --cc=alsa-devel@alsa-project.org \
    --cc=david.henningsson@canonical.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.