All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Lydia Wang <lydiawang@viatech.com.cn>
Cc: alsa-devel@alsa-project.org, HaraldWelte@viatech.com
Subject: Re: [PATCH 10/16] ALSA: VIA HDA: Add support for VT1705
Date: Mon, 21 Mar 2011 13:07:55 +0100	[thread overview]
Message-ID: <s5hmxkor810.wl%tiwai@suse.de> (raw)
In-Reply-To: <4D86FF0A.4090107@viatech.com.cn>

At Mon, 21 Mar 2011 15:32:26 +0800,
Lydia Wang wrote:
> 
> +/* add playback controls from the parsed DAC table */
> +static int vt1705_auto_create_multi_out_ctls(struct via_spec *spec,
> +					     const struct auto_pin_cfg *cfg)
> +{
> +	char name[32];
> +	static const char * const chname[3] = { "Front", "Surround", "C/LFE" };
> +	hda_nid_t nid_vols[] = {0x10, 0x11, 0x25};
> +	hda_nid_t nid_mutes[] = {0x1C, 0x18, 0x27};

So... this function is identical with others except for the NID array
contents and the max number of channels (up to 6).  Can we merge them
with some additional parameters instead of adding yet-another-new one?


thanks,

Takashi

      reply	other threads:[~2011-03-21 12:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-21  7:32 [PATCH 10/16] ALSA: VIA HDA: Add support for VT1705 Lydia Wang
2011-03-21 12:07 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hmxkor810.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=HaraldWelte@viatech.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=lydiawang@viatech.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.