From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH] sound: fix incorrect use
	of	platform_device_register()
Date: Mon, 23 Apr 2007 11:55:23 +0200
Message-ID: <s5hmz0zv2ic.wl%tiwai@suse.de>
References: <20070421072339.GA3699@APFDCB5C>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15])
	by alsa0.perex.cz (Postfix) with ESMTP id 036DA24847
	for <alsa-devel@alsa-project.org>;
	Mon, 23 Apr 2007 11:55:24 +0200 (CEST)
In-Reply-To: <20070421072339.GA3699@APFDCB5C>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Sender: alsa-devel-bounces@alsa-project.org
Errors-To: alsa-devel-bounces@alsa-project.org
To: Akinobu Mita <akinobu.mita@gmail.com>
Cc: alsa-devel@alsa-project.org, Jaroslav Kysela <perex@suse.cz>
List-Id: alsa-devel@alsa-project.org

At Sat, 21 Apr 2007 16:23:39 +0900,
Akinobu Mita wrote:
> 
> The platform_device allocated by platform_device_alloc()
> should be added to the device hierarchy by platform_device_add()
> instead of platform_device_register().
> 
> Otherwise it will hit WARN_ON() in platform_device_register().
> by illegal refcount.
> 
> This patch fixes such incorrect usages in portman2x4 and mts64 drivers.
> Also it removes unnecessary trailing whitespaces.
> 
> Cc: Jaroslav Kysela <perex@suse.cz>
> Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>

Thanks, applied to ALSA tree now.


Takashi