From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.suse.de (cantor.suse.de [195.135.220.2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx1.suse.de", Issuer "Thawte Premium Server CA" (verified OK)) by ozlabs.org (Postfix) with ESMTP id 9C28E67B20 for ; Tue, 30 May 2006 23:35:15 +1000 (EST) Date: Tue, 30 May 2006 15:35:11 +0200 Message-ID: From: Takashi Iwai To: Johannes Berg Subject: Re: [Alsa-devel] [RFC 4/7] snd-aoa: add codecs In-Reply-To: <1148995575.4372.5.camel@johannes> References: <20060528190026.754474000@johannes.berg> <20060528190125.927852000@johannes.berg> <1148992996.3102.8.camel@johannes> <1148995575.4372.5.camel@johannes> MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: linuxppc-dev@ozlabs.org, alsa-devel@alsa-project.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , At Tue, 30 May 2006 15:26:10 +0200, Johannes Berg wrote: > > > > > > + return 1; > > > > > > > > The put callback is supposed to return 0 if the values are unchanged > > > > (although most apps ignore the return value). > > > > > > Does it have to? This way there's an event, but... > > > > Yes, in principle. As mentioned, it works even without the check, > > though. > > Hmm. I thought it worked like this: > 0 -> no change > 1 -> change applied, and other apps are notified, 0 returned to the app > -err -> error returned to app > > Is that wrong? It's correct. And I thought the put callbacks in your code always return either 1 or -err? Takashi