From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH] driver/pci/asihpi.c fix segfault ASI87xx Date: Tue, 08 Feb 2005 21:33:41 +0100 Message-ID: References: <200502081350.28474.linux@blennerhassett.gen.nz> Mime-Version: 1.0 (generated by SEMI 1.14.5 - "Awara-Onsen") Content-Type: text/plain; charset=US-ASCII Received: from Cantor.suse.de (cantor.suse.de [195.135.220.2]) by alsa.alsa-project.org (ALSA's E-mail Delivery System) with ESMTP id B15D625A for ; Tue, 8 Feb 2005 21:33:53 +0100 (MET) In-Reply-To: <200502081350.28474.linux@blennerhassett.gen.nz> Sender: alsa-devel-admin@lists.sourceforge.net Errors-To: alsa-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: To: Eliot Blennerhassett Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org Hi Eliot, At Tue, 8 Feb 2005 13:50:28 +1300, Eliot Blennerhassett wrote: > > Sampleclock control was assumed to exist, actually doesn't in some adapters. > Add error return checks so use of invalid return value doesn't result > (sometimes) in segfault. Looks like your mailer broke the patch. Please attach the patch instead of pasting. Also, don't forget to give "Signed-off-by" for changelog. thanks, Takashi ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click