From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH] Support for Audigy2 Value SB0400 Date: Mon, 22 Nov 2004 18:59:46 +0100 Message-ID: References: <419FF760.8050200@superbug.co.uk> <1101145818.2873.6.camel@krustophenia.net> Mime-Version: 1.0 (generated by SEMI 1.14.5 - "Awara-Onsen") Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: <1101145818.2873.6.camel@krustophenia.net> Sender: alsa-devel-admin@lists.sourceforge.net Errors-To: alsa-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: To: Lee Revell Cc: James Courtier-Dutton , alsa-devel List-Id: alsa-devel@alsa-project.org At Mon, 22 Nov 2004 12:50:18 -0500, Lee Revell wrote: > > On Mon, 2004-11-22 at 14:27 +0100, Takashi Iwai wrote: > > The patch looks fine. Could you provide the nice patch description > > and the signed-off-by lines? > > Also, I noticed the patch contains some /proc changes. Care to comment > a little on these? I was also planning to improve the /proc support, > but don't want to duplicate any work. Yep, at best, the patch should be splitting three parts with summary, descrption and signed-off-by lines for each: - fix for snd_emu10k1_compose_audigy_*() macros - addition of Audigy2 Value support - addition to proc for register dump James, could you do this? thanks, Takashi ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://productguide.itmanagersjournal.com/