Re: [PATCH] Splitting CONFIG_SND_POWERMAC

[Takashi Iwai <tiwai@suse.de>]

At Sun, 14 Mar 2004 23:59:51 -0500 (EST),
Pavel Roskin wrote:
> 
> [1  <text/plain; US-ASCII (7bit)>]
> Hello!
> 
> I was compiling Linux 2.6.x for PowerPC and got compile errors:
> 
> sound/built-in.o(.text+0x28828): In function `daca_init_client':
> : undefined reference to `i2c_smbus_write_byte_data'
> sound/built-in.o(.text+0x28840): In function `daca_init_client':
> : undefined reference to `i2c_smbus_write_byte_data'
> sound/built-in.o(.text+0x2885c): In function `daca_init_client':
> : undefined reference to `i2c_smbus_write_block_data'
> 
> and so on.  It turns out CONFIG_SND_POWERMAC should not be enabled without
> CONFIG_I2C.  My first idea was to add a dependency.
> 
> However, the kernel finds Burgundy sound chip on my PowerPC.  The code for
> Burgundy doesn't use I2C.  I have to enable CONFIG_I2C (without any
> drivers) just to satisfy the linker.
> 
> I think ideally the driver should be split into the base powermac driver
> and 3 specific drivers - AWACS, Burgundy and Keywest, the later being
> dependent on I2C.
> 
> The attached patch implements an interim solution - there is still one
> module, but the user can select what hardware the module supports.  Only
> Keywest devices require I2C.

thanks for the patch.

in fact, i've also thought of splitting this stuff (as you can see it
in the code).  the major drawback by split is that you have to detect
what chip is used on your machine.  and on powermac, it's not easy to
guess like PCI soundcards...


Takashi


-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click