Re: [PATCH] AD1985 mixer settings

[Takashi Iwai <tiwai@suse.de>]

At Sun, 24 Aug 2003 00:29:07 +0200,
Thierry Vignaud wrote:
> 
> Clemens Ladisch <clemens@ladisch.de> writes:
> 
> > Index: alsa-kernel/pci/ac97/ac97_patch.c
> > ===================================================================
> > RCS file: /cvsroot/alsa/alsa-kernel/pci/ac97/ac97_patch.c,v
> > retrieving revision 1.18
> > diff -u -r1.18 ac97_patch.c
> > --- alsa-kernel/pci/ac97/ac97_patch.c	30 Jul 2003 10:54:03 -0000	1.18
> > +++ alsa-kernel/pci/ac97/ac97_patch.c	20 Aug 2003 06:59:16 -0000
> > @@ -768,7 +768,8 @@
> >  	misc = snd_ac97_read(ac97, AC97_AD_MISC);
> >  	/* switch front/surround line-out/hp-out */
> >  	/* center/LFE, surround in High-Z mode */
> > +	/* ADI compatibility mode */
> > -	snd_ac97_write_cache(ac97, AC97_AD_MISC, misc | 0x1c28);
> > +	snd_ac97_write_cache(ac97, AC97_AD_MISC, misc | 0x5c20);
> >  	return 0;
> >  }
> 
> wouldn't a BIT_FEATURE_X & BIT_FEATURE_Y be more readable than raw
> constants ?

yeah, of course :)
i'll try to fix them now.


Takashi


-------------------------------------------------------
This SF.net email is sponsored by: VM Ware
With VMware you can run multiple operating systems on a single machine.
WITHOUT REBOOTING! Mix Linux / Windows / Novell virtual machines
at the same time. Free trial click here:http://www.vmware.com/wl/offer/358/0