Re: EWX 24/96 SPDIF input problem with 0.9.4 (and "compiler.h")

[Takashi Iwai <tiwai@suse.de>]

Hi,

At Tue, 17 Jun 2003 09:50:29 +0200,
Denis Sbragion wrote:
> 
> Hello all,
> 
> I found that the SPDIF input on my TerraTec EWX 24/96 no longer works with 
> the latest 0.9.4 drivers. I digged into the cs8427.c code and I found that 
> this lines in function 'snd_cs8427_create' of version 0.9.3:
> 
> ...
> /* CS8427_REG_RECVERRMASK: unmask the input PLL clock, V, confidence, 
> biphase, parity status bits */
> /* CS8427_UNLOCK | CS8427_V | CS8427_CONF | CS8427_BIP | CS8427_PAR,
> Why setting CS8427_V causes clicks and glitches? */
> CS8427_UNLOCK | CS8427_CONF | CS8427_BIP | CS8427_PAR,
> ...
> 
> have been changed into:
> 
> ...
> /* CS8427_REG_RECVERRMASK: unmask the input PLL clock, V, confidence, 
> biphase, parity status bits */
> /* CS8427_UNLOCK | CS8427_V | CS8427_CONF | CS8427_BIP | CS8427_PAR, * /
> 0xff, /* set everything */
> ...
> 
> in version 0.9.4, along with some other changes. The "Why setting CS8427_V 
> causes clicks and glitches?" comment of version 0.9.3 comes from an old 
> patch I sent to Jaroslav many months ago, when I had a similar problem with 
> an older 0.9.0something version of the drivers. The fact that this patch 
> has been rolled back makes me think that there are some other cards out 
> there that need that flag, so I think that a card dependent intialization 
> is needed here, but I don't know how to code it. Of course I'm willing to 
> help in coding and testing everything that may be needed to make the driver 
> run, though I can only test on my own EWX. Relevant environment: RedHat 
> Linux 7.2, 2.4.7 kernel.

thanks for spotting this out.

as you suggested above, i added the ews-specific initialization
there.  it just resets the RECVERRMASK register afterwards in
ews.c.  please try the cvs version.


> 	I found also that the adriver.h file in version 0.9.4 includes the file 
> "linux/compiler.h", which is not present on older 2.4 kernels like my 
> 2.4.7. Everything seems to compile pretty well even without this include, 
> at least on 2.4.7, so may be a conditional inclusion is needed here.

this should have been fixed on the cvs.  it will create a dummy
linux/compiler.h if not found.


ciao,

Takashi


-------------------------------------------------------
This SF.Net email sponsored by: Free pre-built ASP.NET sites including
Data Reports, E-commerce, Portals, and Forums are available now.
Download today and enter to win an XBOX or Visual Studio .NET.
http://aspnet.click-url.com/go/psa00100006ave/direct;at.asp_061203_01/01