From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: patch for hammerfall driver Date: Tue, 04 Feb 2003 12:10:04 +0100 Sender: alsa-devel-admin@lists.sourceforge.net Message-ID: References: Mime-Version: 1.0 (generated by SEMI 1.14.4 - "Hosorogi") Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: Errors-To: alsa-devel-admin@lists.sourceforge.net List-Help: List-Post: List-Subscribe: , List-Unsubscribe: , List-Archive: To: Paul Davis Cc: "John S. Denker" , alsa-devel@lists.sourceforge.net List-Id: alsa-devel@alsa-project.org At Mon, 03 Feb 2003 09:49:59 -0500, Paul Davis wrote: > > >> To be explicit: whenever you see a bug, don't just > >> ask how to fix this instance of the bug; ask what > >> it would take to make sure no bug of this ilk ever > >> occurs again. > >> > >> In this case: > >> a) It would help to have some comments in the code > >> saying where the constants are coming from, so that > >> misconceptions can be more easily spotted. > >> b) It would help to use correctly computed constants > >> such as > > actually, neither would have really helped very much here. i don't > know who set the values to those that were here before. the values > were clearly wrong on any reading of the code, and i've thought about > them on previous readings. the values that were there before were not > "buggy" - they were completely wrong. i also don't know how they got in, but at least the values were already there more than one year ago... Takashi ------------------------------------------------------- This SF.NET email is sponsored by: SourceForge Enterprise Edition + IBM + LinuxWorld = Something 2 See! http://www.vasoftware.com