Re: alsa-driver-0.9.0rc3 patch

[Takashi Iwai <tiwai@suse.de>]

At Thu, 12 Sep 2002 17:10:44 +0100,
Ian Grant wrote:
> 
> > At Thu, 12 Sep 2002 16:23:56 +0100,
> > Ian Grant wrote:
> > > 
> > > Here is a patch for the toplevel Makefile to remove the $DESTDIR from the path 
> > > of the System.map file where we check for its existence. This makes the 
> > > existence check test the same file location as is used in the subsequent -F 
> > > option to depmod. It works for me!
> > 
> > $DESTDIR is necessary in path, too, because depmod is invoked with
> > "-b $DESTDIR" option.  the system-map path becomes relative to the
> > $DESTDIR, then. 
> 
> I don't think this is correct. The system map is loaded only at the time 
> depmod is run and comes from the kernel build directory 
> $(CONFIG_SND_KERNELDIR); its path is not modified by the -b option. The kernel 
> build directory is an absolute path to some scratch space somewhere - a home 
> directory perhaps. $DESTDIR is the place where the modules will be installed 
> so there is no System.map under $(DESTDIR)$(CONFIG_SND_KERNELDIR), but in the 
> Makefile that is what is tested before it is decided to supply the
> 
>        -F $(CONFIG_SND_KERNELDIR)/Sytem.map
> 
> option to depmod.
> 
> My patch brings the test in line with the option. I cannot see why these two 
> things should be different.

ok, now it's fixed on cvs.

thanks,


Takashi


-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf