From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 48D65C433FE for ; Mon, 13 Dec 2021 14:07:43 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 316E417E6; Mon, 13 Dec 2021 15:06:51 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 316E417E6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1639404461; bh=iAvrQ8XEzDceOZPjigNNxl5CqDvdHdW+qDFnx+x+aQU=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=XtSKuo46+jKaa7B3Y0GZggUsscmyDP0iShMzbnJ0fso4piBHkyWCNCTghVSJU+gzM 7E4MJNoGZM9riwk0/xAzRamHyWRL25fuluC2larL68ptwm+dYaoMOs06bFoZoODEQt Da6NTyP5b8+PF1Ny8y7YNgH1J/QSQBZIpQcYQpuw= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id BFD51F80229; Mon, 13 Dec 2021 15:06:50 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 3F96FF8025D; Mon, 13 Dec 2021 15:06:49 +0100 (CET) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 48C0EF8013C for ; Mon, 13 Dec 2021 15:06:42 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 48C0EF8013C Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="DvIzvCp+"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="EXpcgZBP" Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 715641F3C4; Mon, 13 Dec 2021 14:06:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1639404402; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dpLgqI5Tw3GnoBgcEXRU3pdXJNavl+OqZ3p93cVVH4U=; b=DvIzvCp+C0UBSiJU0mBiiRkGMsTjFOb8aXxxXs1ORIIDCz3FXY6txJmzaHIKV82D+KsGXN sYmn4UZN29+NtcoKMrmh6FLFLSOkiGRSlD91ulANXJ0c2vLf9Hdr9bDoxmOfKaQj0ot78p LCXOK7wLfglROlAvhhCM7QI/Te3UDNU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1639404402; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dpLgqI5Tw3GnoBgcEXRU3pdXJNavl+OqZ3p93cVVH4U=; b=EXpcgZBPdi5ULixzRADj8QYZYG3ywFXnPpkXyNw8YdAOqWr5Dd+28q5QeecJaFTYKzfXrl tdLY3iw1bnbW66BQ== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 61B15A3BB2; Mon, 13 Dec 2021 14:06:42 +0000 (UTC) Date: Mon, 13 Dec 2021 15:06:42 +0100 Message-ID: From: Takashi Iwai To: Jaroslav Kysela Subject: Re: [PATCH 2/2] ALSA: gus: Fix memory leaks at error paths in memory allocations In-Reply-To: References: <20211213132444.22385-1-tiwai@suse.de> <20211213132444.22385-2-tiwai@suse.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: ALSA development X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Mon, 13 Dec 2021 15:02:46 +0100, Jaroslav Kysela wrote: > > On 13. 12. 21 14:24, Takashi Iwai wrote: > > When snd_gf1_mem_xalloc() returns NULL, the current code still leaves > > the formerly allocated block.name string but returns an error > > immediately. This patch covers the all callers to deal with the > > release of leftover name strings in the error paths. > > > > Signed-off-by: Takashi Iwai > > It may be easier to pass the name to snd_gf1_mem_xalloc() - the code flow is more readable: (snip) Thanks, looks like a good idea. Since the kstrdup() NULL check fix was already applied, I'll resubmit with the new one. Takashi