From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 114B0C433DB for ; Thu, 14 Jan 2021 14:05:24 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 44D4C23A6A for ; Thu, 14 Jan 2021 14:05:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 44D4C23A6A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 4C1C616BA; Thu, 14 Jan 2021 15:04:26 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 4C1C616BA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1610633116; bh=VLK6G5GLWpa2dcecEZUYEjGyoG92ubELlwOVAKA6VA8=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=ITPLPXtV6erT1RvzZA9N6Ry8QSM9yYOu3wZY2KlisIEiL9B8qOv1gHqWu6BdRTzw0 3ChiRo7s2vLlG5tE0gZewoDIol7quKgFAMqM15oYsPxmDNWNW/AHy12a+JMi3kKldJ HEmu/ZjCU74NvRphWRJyfU9KrIOKJ2XGFwVV9avk= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 49E92F80113; Thu, 14 Jan 2021 15:04:25 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 56337F80249; Thu, 14 Jan 2021 15:04:22 +0100 (CET) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 3D079F80134 for ; Thu, 14 Jan 2021 15:04:19 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 3D079F80134 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 5422AAD11; Thu, 14 Jan 2021 14:04:19 +0000 (UTC) Date: Thu, 14 Jan 2021 15:04:19 +0100 Message-ID: From: Takashi Iwai To: Kai Vehmanen Subject: Re: [PATCH v2] ASoC: SOF: Intel: initial support to AlderLake-P In-Reply-To: References: <20210114115558.52699-1-kai.vehmanen@linux.intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: Guennadi Liakhovetski , alsa-devel@alsa-project.org, daniel.baluta@nxp.com, ranjani.sridharan@linux.intel.com, lgirdwood@gmail.com, broonie@kernel.org, pierre-louis.bossart@linux.intel.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, 14 Jan 2021 14:45:10 +0100, Kai Vehmanen wrote: > > Hi, > > On Thu, 14 Jan 2021, Takashi Iwai wrote: > > > On Thu, 14 Jan 2021 12:55:58 +0100, Kai Vehmanen wrote: > > > --- a/sound/soc/sof/sof-pci-dev.c > > > +++ b/sound/soc/sof/sof-pci-dev.c > [...] > > > -#if IS_ENABLED(CONFIG_SND_SOC_SOF_TIGERLAKE) > > > +#if IS_ENABLED(CONFIG_SND_SOC_SOF_TIGERLAKE) || IS_ENABLED(CONFIG_SND_SOC_SOF_ALDERLAKE) > > > static const struct sof_dev_desc tgl_desc = { > > > .machines = snd_soc_acpi_intel_tgl_machines, > > > .alt_machines = snd_soc_acpi_intel_tgl_sdw_machines, > > > > I guess snd_soc_acpi_intel_tgl_* would be missing even by this patch > > alone if TIGERLAKE=n and ALDERLAKE=y. > > The ACPI matching tables soc-acpi-intel-match.h are not behind Kconfig > ifdefs, so this is ok. I did actually test all the build combinations this > time :) and the builds go through. > > > IMO, the easiest fix would be to select CONFIG_SND_SOC_SOF_TIGERLAKE > > from CONFIG_SND_SOC_SOF_ALDERLAKE forcibly in Kconfig instead. Then > > no tweak of ifdef is needed. > > I'd rather keep this here. We may later update sof_dev_desc for ADL and no > longer reuse tgl_desc, and then it's easier to cleanup if the #ifdef is > only here, close to where the dependency is. > > I too think the ifdefs are too finegrained, so maybe the next step is to > just drop these, and/or reduce their number. We can review and discuss > this when we refactor sof-pci-dev to address the concern Arnd raised. Fair enough. Thanks. Takashi