* [PATCH lib] control: complement comment for subscribe API
@ 2015-02-09 15:18 Takashi Sakamoto
2015-02-09 15:22 ` Takashi Sakamoto
2015-02-09 15:27 ` [PATCH v2] " Takashi Sakamoto
0 siblings, 2 replies; 4+ messages in thread
From: Takashi Sakamoto @ 2015-02-09 15:18 UTC (permalink / raw)
To: o-takashi, tiwai, clemens; +Cc: alsa-devel, Takashi Sakamoto
From: Takashi Sakamoto <mocchi@Mocchi64.miraclelinux.com>
When minus value is given as a parameter, the API returns whether
the caller has already subscribed or not.
This commit adds a comment about this so as better documentation.
Signed-off-by: Takashi Sakamoto <mocchi@Mocchi64.miraclelinux.com>
---
src/control/control.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/control/control.c b/src/control/control.c
index dd428a1..4a28cf6 100644
--- a/src/control/control.c
+++ b/src/control/control.c
@@ -213,7 +213,7 @@ int snd_ctl_poll_descriptors_revents(snd_ctl_t *ctl, struct pollfd *pfds, unsign
/**
* \brief Ask to be informed about events (poll, #snd_async_add_ctl_handler, #snd_ctl_read)
* \param ctl CTL handle
- * \param subscribe 0 = unsubscribe, 1 = subscribe
+ * \param subscribe 0 = unsubscribe, 1 = subscribe, -1 = check subscribe or not
* \return 0 on success otherwise a negative error code
*/
int snd_ctl_subscribe_events(snd_ctl_t *ctl, int subscribe)
--
2.1.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH lib] control: complement comment for subscribe API
2015-02-09 15:18 [PATCH lib] control: complement comment for subscribe API Takashi Sakamoto
@ 2015-02-09 15:22 ` Takashi Sakamoto
2015-02-09 15:27 ` [PATCH v2] " Takashi Sakamoto
1 sibling, 0 replies; 4+ messages in thread
From: Takashi Sakamoto @ 2015-02-09 15:22 UTC (permalink / raw)
To: tiwai, clemens; +Cc: alsa-devel, Takashi Sakamoto
Oops. I passed a wrong value to signed-off-by field...
Please abandon this message, sorry.
Regards
Takashi Sakamoto
On Feb 10 2015 00:18, Takashi Sakamoto wrote:
> From: Takashi Sakamoto <mocchi@Mocchi64.miraclelinux.com>
>
> When minus value is given as a parameter, the API returns whether
> the caller has already subscribed or not.
>
> This commit adds a comment about this so as better documentation.
>
> Signed-off-by: Takashi Sakamoto <mocchi@Mocchi64.miraclelinux.com>
> ---
> src/control/control.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/control/control.c b/src/control/control.c
> index dd428a1..4a28cf6 100644
> --- a/src/control/control.c
> +++ b/src/control/control.c
> @@ -213,7 +213,7 @@ int snd_ctl_poll_descriptors_revents(snd_ctl_t *ctl, struct pollfd *pfds, unsign
> /**
> * \brief Ask to be informed about events (poll, #snd_async_add_ctl_handler, #snd_ctl_read)
> * \param ctl CTL handle
> - * \param subscribe 0 = unsubscribe, 1 = subscribe
> + * \param subscribe 0 = unsubscribe, 1 = subscribe, -1 = check subscribe or not
> * \return 0 on success otherwise a negative error code
> */
> int snd_ctl_subscribe_events(snd_ctl_t *ctl, int subscribe)
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] control: complement comment for subscribe API
2015-02-09 15:18 [PATCH lib] control: complement comment for subscribe API Takashi Sakamoto
2015-02-09 15:22 ` Takashi Sakamoto
@ 2015-02-09 15:27 ` Takashi Sakamoto
2015-02-09 15:35 ` Takashi Iwai
1 sibling, 1 reply; 4+ messages in thread
From: Takashi Sakamoto @ 2015-02-09 15:27 UTC (permalink / raw)
To: o-takashi, tiwai, clemens; +Cc: alsa-devel
When minus value is given as a parameter, the API returns whether
the caller has already subscribed or not.
This commit adds a comment about this so as better documentation.
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
---
src/control/control.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/control/control.c b/src/control/control.c
index dd428a1..4a28cf6 100644
--- a/src/control/control.c
+++ b/src/control/control.c
@@ -213,7 +213,7 @@ int snd_ctl_poll_descriptors_revents(snd_ctl_t *ctl, struct pollfd *pfds, unsign
/**
* \brief Ask to be informed about events (poll, #snd_async_add_ctl_handler, #snd_ctl_read)
* \param ctl CTL handle
- * \param subscribe 0 = unsubscribe, 1 = subscribe
+ * \param subscribe 0 = unsubscribe, 1 = subscribe, -1 = check subscribe or not
* \return 0 on success otherwise a negative error code
*/
int snd_ctl_subscribe_events(snd_ctl_t *ctl, int subscribe)
--
2.1.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] control: complement comment for subscribe API
2015-02-09 15:27 ` [PATCH v2] " Takashi Sakamoto
@ 2015-02-09 15:35 ` Takashi Iwai
0 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2015-02-09 15:35 UTC (permalink / raw)
To: Takashi Sakamoto; +Cc: alsa-devel, clemens
At Tue, 10 Feb 2015 00:27:19 +0900,
Takashi Sakamoto wrote:
>
> When minus value is given as a parameter, the API returns whether
> the caller has already subscribed or not.
>
> This commit adds a comment about this so as better documentation.
>
> Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Applied, thanks.
Takashi
> ---
> src/control/control.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/control/control.c b/src/control/control.c
> index dd428a1..4a28cf6 100644
> --- a/src/control/control.c
> +++ b/src/control/control.c
> @@ -213,7 +213,7 @@ int snd_ctl_poll_descriptors_revents(snd_ctl_t *ctl, struct pollfd *pfds, unsign
> /**
> * \brief Ask to be informed about events (poll, #snd_async_add_ctl_handler, #snd_ctl_read)
> * \param ctl CTL handle
> - * \param subscribe 0 = unsubscribe, 1 = subscribe
> + * \param subscribe 0 = unsubscribe, 1 = subscribe, -1 = check subscribe or not
> * \return 0 on success otherwise a negative error code
> */
> int snd_ctl_subscribe_events(snd_ctl_t *ctl, int subscribe)
> --
> 2.1.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-02-09 15:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-09 15:18 [PATCH lib] control: complement comment for subscribe API Takashi Sakamoto
2015-02-09 15:22 ` Takashi Sakamoto
2015-02-09 15:27 ` [PATCH v2] " Takashi Sakamoto
2015-02-09 15:35 ` Takashi Iwai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.