All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: renu.tyagi@samsung.com
Cc: alsa-devel@alsa-project.org
Subject: Re: coverity fix in alsa-libs
Date: Thu, 18 Sep 2014 09:11:35 +0200	[thread overview]
Message-ID: <s5hoaud8kt4.wl-tiwai@suse.de> (raw)
In-Reply-To: <B6.74.04938.0385A145@epcpsbgx1.samsung.com> <26983035.79381411012655765.JavaMail.weblogic@epv6ml12>

At Thu, 18 Sep 2014 03:57:36 +0000 (GMT),
Renu Tyagi wrote:
> 
> Hi, 
> 
> Sorry for the spam mail. I am sending the mail in plain text now.
> PFA patch. 
> File in which changes are being made : rawmidi.c
> Bug type - Handle h to be closed in case of error before returning 
> Meanwhile I am looking into the matter why my mails are not visible in ML.

I see now on ML, so the problem was your post in HTML, indeed.

Regarding the patch: I see only a few cosmetic issue.

- Use embedded in the mail as much as possible rather than an
  attachment.  This makes review much easier.

- Put your real name in sign-off-by (and also From: line).  Refer to
  Documentation/SubmittingPatches in Linux kernel tree about the
  meaning of this line. 

- Put a space before the open brace.

- Add some prefix in the subject line to identify the area; in this
  case, add like "rawmidi: Handle d to be ...."
 

thanks,

Takashi

       reply	other threads:[~2014-09-18  7:11 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <B6.74.04938.0385A145@epcpsbgx1.samsung.com>
     [not found] ` <26983035.79381411012655765.JavaMail.weblogic@epv6ml12>
2014-09-18  7:11   ` Takashi Iwai [this message]
2014-09-18  3:57 coverity fix in alsa-libs Renu Tyagi
     [not found] <0A.06.05230.43DF8145@epcpsbgx3.samsung.com>
2014-09-17  5:52 ` Takashi Iwai
     [not found] <1E.9D.05030.0D7B7145@epcpsbgx4.samsung.com>
2014-09-16 14:40 ` Takashi Iwai
  -- strict thread matches above, loose matches on Subject: below --
2014-09-15  9:25 Renu Tyagi
2014-09-15 11:36 ` Alexander E. Patrakov
2014-09-15 11:48   ` Takashi Iwai
2014-09-15 11:50     ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hoaud8kt4.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=renu.tyagi@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.