From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH] firewire-speakers: remove not-reused member from structure Date: Tue, 09 Jul 2013 18:21:35 +0200 Message-ID: References: <1373383366-14340-1-git-send-email-o-takashi@sakamocchi.jp> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 65D5726558F for ; Tue, 9 Jul 2013 18:20:22 +0200 (CEST) In-Reply-To: <1373383366-14340-1-git-send-email-o-takashi@sakamocchi.jp> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Takashi Sakamoto Cc: alsa-devel@alsa-project.org, clemens@ladisch.de List-Id: alsa-devel@alsa-project.org At Wed, 10 Jul 2013 00:22:46 +0900, Takashi Sakamoto wrote: > > "pcm" member in struct fwspk is used to set pcm operations but is not used > again. This commit remove this member and set pcm operations with > snd_pcm_set_ops(). > > Signed-off-by: Takashi Sakamoto Thanks, I'll queue it once when the merge window is closed (thus it's opened again for 3.12 development). Takashi > --- > sound/firewire/speakers.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/sound/firewire/speakers.c b/sound/firewire/speakers.c > index 2c63865..fe9e6e2 100644 > --- a/sound/firewire/speakers.c > +++ b/sound/firewire/speakers.c > @@ -49,7 +49,6 @@ struct fwspk { > struct snd_card *card; > struct fw_unit *unit; > const struct device_info *device_info; > - struct snd_pcm_substream *pcm; > struct mutex mutex; > struct cmp_connection connection; > struct amdtp_out_stream stream; > @@ -363,8 +362,7 @@ static int fwspk_create_pcm(struct fwspk *fwspk) > return err; > pcm->private_data = fwspk; > strcpy(pcm->name, fwspk->device_info->short_name); > - fwspk->pcm = pcm->streams[SNDRV_PCM_STREAM_PLAYBACK].substream; > - fwspk->pcm->ops = &ops; > + snd_pcm_set_ops(pcm, SNDRV_PCM_STREAM_PLAYBACK, &ops); > return 0; > } > > -- > 1.7.10.4 >