Re: [PATCH] ALSA: hda - Add CX20582 and OLPC XO-1.5 support

[Takashi Iwai <tiwai@suse.de>]

At Thu, 16 Jul 2009 14:59:56 +0100,
Daniel Drake wrote:
> 
> On Thu, 2009-07-16 at 15:53 +0200, Takashi Iwai wrote:
> > At Thu, 16 Jul 2009 14:46:57 +0100 (BST),
> > Daniel Drake wrote:
> > > 
> > > This adds support for the Conexant CX20582 codec, based on code from
> > > http://www.linuxant.com/alsa-driver/alsa-driver-linuxant-1.0.19ppch12-1.noarch.rpm.zip
> > > 
> > > This is the codec to be shipped in the OLPC XO-1.5, so this patch also
> > > includes an XO-specific profile. Resultant configuration:
> > > http://dev.laptop.org/~dsd/20090713/codec0.txt
> > > http://dev.laptop.org/~dsd/20090713/codec0.svg
> > > 
> > > As the Linuxant code is structured differently to the other codecs,
> > > I was unable to cleanly reimplement everything in the generic and Dell
> > > profiles as more info is needed (e.g. codec graphs). I simplified those
> > > profiles so that hopefully it will not break anyone's audio. If it does,
> > > it may be worth returning -ENODEV from patch_cx5066 on non-OLPC systems,
> > > and then fixing snd_hda_codec_configure() to fall back on the generic
> > > parser, at least until support for other systems is figured out.
> > 
> > The patch looks OK.  Could you give your sign-off?
> 
> Sorry, forgot.
> 
> Signed-off-by: Daniel Drake <dsd@laptop.org>

Thanks, applied now.


Takashi