Re: [PATCH] Change the freq limit of speaker-test

[Takashi Iwai <tiwai@suse.de>]

At Tue, 21 Jun 2005 18:14:55 +0300,
Anssi Hannula wrote:
> 
> Takashi Iwai wrote:
> > At Tue, 21 Jun 2005 17:50:36 +0300,
> > Anssi Hannula wrote:
> > 
> >>Takashi Iwai wrote:
> >>
> >>>At Fri, 17 Jun 2005 21:14:48 +0300,
> >>>Anssi Hannula wrote:
> >>>
> >>>>I noticed that the speaker-test has limited sine wave frequency to 
> >>>>50-5000 Hz. Attached patch changes that to 0-24575Hz (that's the limit 
> >>>>at least here (x86-64) after which the freq would roll over to 0 Hz).
> >>>
> >>>Does freq=0 really work?  I think this will result in zero-division.
> >>
> >>Well, it produces the expected output (no sound) and does not crash.
> > 
> > Strange.  Anyway, accepting freq = 0 doesn't make sense.
> > I think we should keep reasonalbe minimal/maximal values to produce
> > tones.
> 
> I understand that 0 doesn't make any sense.
> But I think we should still change the limits, so that users can 
> experiment things and test their hardware (someone asked for tone 
> generator in VDR ml, I replied with speaker-test, but it didn't produce 
> high enough tones) etc, and it wouldn't hurt.

Well, it's a question "what is reasonable".  I see the advantage of
having extreme values, too.  But 0 is not, at least...


Takashi


-------------------------------------------------------
SF.Net email is sponsored by: Discover Easy Linux Migration Strategies
from IBM. Find simple to follow Roadmaps, straightforward articles,
informative Webcasts and more! Get everything you need to get up to
speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click