From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH] emu10k1: split snd_emu10k1_trigger_voice into trigger and prepare functions Date: Mon, 14 Feb 2005 16:34:03 +0100 Message-ID: References: <1108163800.20365.82.camel@krustophenia.net> Mime-Version: 1.0 (generated by SEMI 1.14.5 - "Awara-Onsen") Content-Type: text/plain; charset=US-ASCII In-Reply-To: <1108163800.20365.82.camel@krustophenia.net> Sender: alsa-devel-admin@lists.sourceforge.net Errors-To: alsa-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: To: Lee Revell Cc: alsa-devel , James Courtier-Dutton List-Id: alsa-devel@alsa-project.org At Fri, 11 Feb 2005 18:16:40 -0500, Lee Revell wrote: > > This patch provides better sync between multiple voices by separating > the trigger_voice function into prepare_voice which sets up the volume > and filter parameters and trigger_voice which sets pitch target, current > and initial pitch and enables the voice interrupt. For standard PCM > this should not make much of a difference but will be important for > minimizing phase error between voices for multichannel PCM. > > This behavior was derived from the opensource.creative.com driver. > > Signed-Off-By: Lee Revell Thanks, applied to CVS (with a trivial compile-warning fix). Takashi ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click