From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S268916AbUJUJ0W (ORCPT ); Thu, 21 Oct 2004 05:26:22 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S269056AbUJUJ0L (ORCPT ); Thu, 21 Oct 2004 05:26:11 -0400 Received: from cantor.suse.de ([195.135.220.2]:11430 "EHLO Cantor.suse.de") by vger.kernel.org with ESMTP id S268916AbUJUJZa (ORCPT ); Thu, 21 Oct 2004 05:25:30 -0400 Date: Thu, 21 Oct 2004 11:25:29 +0200 Message-ID: From: Takashi Iwai To: Rusty Russell Cc: Andrew Morton , lkml - Kernel Mailing List Subject: Re: [PATCH] Remove MODULE_PARM from i386 defconfig. In-Reply-To: <1098319932.10571.157.camel@localhost.localdomain> References: <1098258609.10571.145.camel@localhost.localdomain> <1098319932.10571.157.camel@localhost.localdomain> User-Agent: Wanderlust/2.10.1 (Watching The Wheels) SEMI/1.14.5 (Awara-Onsen) FLIM/1.14.5 (Demachiyanagi) APEL/10.6 MULE XEmacs/21.4 (patch 15) (Security Through Obscurity) (i386-suse-linux) MIME-Version: 1.0 (generated by SEMI 1.14.5 - "Awara-Onsen") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org At Thu, 21 Oct 2004 10:52:12 +1000, Rusty Russell wrote: > > On Wed, 2004-10-20 at 21:23, Takashi Iwai wrote: > > Hi Rusty, > > > > At Wed, 20 Oct 2004 17:50:09 +1000, > > Rusty Russell wrote: > > > @@ -749,8 +749,8 @@ static int parport_nr[LP_NO] = { [0 ... > > > static char *parport[LP_NO] = { NULL, }; > > > static int reset = 0; > > > > > > -MODULE_PARM(parport, "1-" __MODULE_STRING(LP_NO) "s"); > > > -MODULE_PARM(reset, "i"); > > > +module_param_array(parport, charp, NULL, 0); > > > > Can module_param_array() now take NULL for the third argument? > > Yes, it was looking at the ALSA code in particular that I decided we > needed this, and hence the change. My patch cleans most of those up, I > think. Great, thanks! Takashi