From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6566AC433EF for ; Mon, 6 Dec 2021 09:08:30 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 9484C1F5A; Mon, 6 Dec 2021 10:07:38 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 9484C1F5A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1638781708; bh=IphYrt5nQxd56MpcGhio86H57bhGwmEvgVpFjvxOPvc=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Gkz1xpbleJK+RWOno0wFOjJMM6xr0GM6SsaKMFfsS6OVvR9+GbYjts9e0dSI/34Qn dRHagkHuV6R0HbCXRlSjTVmJZJ4xG3CQvcsd1hsd3vRmSDjYugzkRTvpjFsJQy/rmw jISgU01NJMZyiMGBNyO784CrP0+5+sT7M+GfcMBk= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 3FFAAF8020B; Mon, 6 Dec 2021 10:07:38 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 486BCF8026C; Mon, 6 Dec 2021 10:07:37 +0100 (CET) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 68D03F80118 for ; Mon, 6 Dec 2021 10:07:31 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 68D03F80118 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="vovqJyG1"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="u41FBGWI" Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 613CD1FD59; Mon, 6 Dec 2021 09:07:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1638781650; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kIdsvKanlrdX4YaSaYvfrT4WVmDy50bs35ZxRhqdGKY=; b=vovqJyG1WPtdxWDP50szLqLGcn+qGr2L1Cdpcas4T8sJoZtZN8I3WVB1k57K6HYG+9GDdP Nu8ngfDMj1L3Wg4Gb1lng/CqiLzv3jkFadZoGbVA6dZzo+Kt6wWuFqBFLLHZJ6wzOZpVYm VvQCXT3WbTPp+2FM+xhsdJIccIlgnwU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1638781650; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kIdsvKanlrdX4YaSaYvfrT4WVmDy50bs35ZxRhqdGKY=; b=u41FBGWI3jahmGYyeTU7pBlg1RK4+auYZ7VUp2A0HMi2RcCmb8ri9H3qoA5UiambzYRnSJ S2E1CgAE946Wk4DA== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 5358CA3B81; Mon, 6 Dec 2021 09:07:30 +0000 (UTC) Date: Mon, 06 Dec 2021 10:07:30 +0100 Message-ID: From: Takashi Iwai To: Geraldo Nascimento Subject: Re: [PATCH v2] ALSA: usb-audio: Reorder snd_djm_devices[] entries In-Reply-To: References: User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: William Overton , ALSA-devel , Olivia Mackintosh X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Sat, 04 Dec 2021 19:52:24 +0100, Geraldo Nascimento wrote: > > Olivia Mackintosh has posted to alsa-devel reporting that > there's a potential bug that could break mixer quirks for Pioneer > devices introduced by 6d27788160362a7ee6c0d317636fe4b1ddbe59a7 > "ALSA: usb-audio: Add support for the Pioneer DJM 750MK2 > Mixer/Soundcard". > > This happened because the DJM 750 MK2 was added last to the Pioneer DJM > device table index and defined as 0x4 but was added to snd_djm_devices[] > just after the DJM 750 (MK1) entry instead of last, after the DJM 900 > NXS2. This escaped review. > > To prevent that from ever happening again, Takashi Iwai suggested to use > C99 array designators in snd_djm_devices[] instead of simply reordering > the entries. > > Reported-by: Olivia Mackintosh > Suggested-by: Takashi Iwai > Signed-off-by: Geraldo Nascimento > > --- > > V1 -> V2: added C99 array designators to prevent the order of entries > ever being an issue again. Thanks, applied now with Fixes tag. Takashi