From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AA43C433C1 for ; Fri, 26 Mar 2021 08:02:02 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C782F61A05 for ; Fri, 26 Mar 2021 08:02:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C782F61A05 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 9558015DC; Fri, 26 Mar 2021 09:01:08 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 9558015DC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1616745718; bh=N9qOrr4eR6pH6vwo/Lv/K6t4qTBGJ8kjZ/8o9BYAIwE=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=ImhwI1M03pLnjCHpillN0eCiuwJgo+Atz6toIgTMuDBKsV7jOU8IpqZwUcxDjr93q EoP4osx4hMCIOvk1QkKADGkCVP+MLb//paxGs2XfpTYf6m6xcoyp2UzzuLsiH5RURj eZamkL5IVOxBinccVpd3I8yPMgcwb1P5IBgnN6Ns= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 833F0F80156; Fri, 26 Mar 2021 09:01:07 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 36C9FF800D0; Fri, 26 Mar 2021 09:00:56 +0100 (CET) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 0A875F800D0 for ; Fri, 26 Mar 2021 09:00:42 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 0A875F800D0 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 4B95CAE03; Fri, 26 Mar 2021 08:00:37 +0000 (UTC) Date: Fri, 26 Mar 2021 09:00:37 +0100 Message-ID: From: Takashi Iwai To: Muhammad Usama Anjum Subject: Re: [PATCH] ALSA: usb-audio: Don't store returned value and check for errors In-Reply-To: <20210325083641.GA644957@LEGION> References: <20210325083641.GA644957@LEGION> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Takashi Iwai , colin.king@canonical.com, dan.carpenter@oracle.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, 25 Mar 2021 09:36:41 +0100, Muhammad Usama Anjum wrote: > > The returned value by create_autodetect_quirk isn't being used other > than in the success check on next line. Remove the return value > assignement. Check for error values instead of success check. > > Signed-off-by: Muhammad Usama Anjum > --- > sound/usb/quirks.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c > index 9e5e37eff10e..5ce5f4ecb9d0 100644 > --- a/sound/usb/quirks.c > +++ b/sound/usb/quirks.c > @@ -425,9 +425,9 @@ static int create_autodetect_quirks(struct snd_usb_audio *chip, > USB_CLASS_VENDOR_SPEC) > continue; > > - err = create_autodetect_quirk(chip, iface, driver); > - if (err >= 0) > - usb_driver_claim_interface(driver, iface, (void *)-1L); > + if (create_autodetect_quirk(chip, iface, driver) < 0) > + continue; > + usb_driver_claim_interface(driver, iface, (void *)-1L); Hm, basically this change is only for readability (the code optimization makes almost no sense), and the readability itself isn't improved significantly by this change, either. That is, I'm fine to take this, but OTOH, I see no compelling reason to do so... thanks, Takashi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57A15C433DB for ; Fri, 26 Mar 2021 08:01:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 07F6561A3F for ; Fri, 26 Mar 2021 08:01:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229893AbhCZIBN (ORCPT ); Fri, 26 Mar 2021 04:01:13 -0400 Received: from mx2.suse.de ([195.135.220.15]:39128 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229551AbhCZIAi (ORCPT ); Fri, 26 Mar 2021 04:00:38 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 4B95CAE03; Fri, 26 Mar 2021 08:00:37 +0000 (UTC) Date: Fri, 26 Mar 2021 09:00:37 +0100 Message-ID: From: Takashi Iwai To: Muhammad Usama Anjum Cc: Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, colin.king@canonical.com, dan.carpenter@oracle.com Subject: Re: [PATCH] ALSA: usb-audio: Don't store returned value and check for errors In-Reply-To: <20210325083641.GA644957@LEGION> References: <20210325083641.GA644957@LEGION> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: kernel-janitors@vger.kernel.org On Thu, 25 Mar 2021 09:36:41 +0100, Muhammad Usama Anjum wrote: > > The returned value by create_autodetect_quirk isn't being used other > than in the success check on next line. Remove the return value > assignement. Check for error values instead of success check. > > Signed-off-by: Muhammad Usama Anjum > --- > sound/usb/quirks.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c > index 9e5e37eff10e..5ce5f4ecb9d0 100644 > --- a/sound/usb/quirks.c > +++ b/sound/usb/quirks.c > @@ -425,9 +425,9 @@ static int create_autodetect_quirks(struct snd_usb_audio *chip, > USB_CLASS_VENDOR_SPEC) > continue; > > - err = create_autodetect_quirk(chip, iface, driver); > - if (err >= 0) > - usb_driver_claim_interface(driver, iface, (void *)-1L); > + if (create_autodetect_quirk(chip, iface, driver) < 0) > + continue; > + usb_driver_claim_interface(driver, iface, (void *)-1L); Hm, basically this change is only for readability (the code optimization makes almost no sense), and the readability itself isn't improved significantly by this change, either. That is, I'm fine to take this, but OTOH, I see no compelling reason to do so... thanks, Takashi