From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11B80C54FCC for ; Tue, 21 Apr 2020 19:32:50 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6EAD4206D5 for ; Tue, 21 Apr 2020 19:32:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="Or1KvnN/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6EAD4206D5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id CB39616BA; Tue, 21 Apr 2020 21:31:57 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz CB39616BA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1587497567; bh=zlyvawHECFHKHKSyaaAGp9Wr7uZXfrP1vpSlRHw7EUU=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Or1KvnN/Q2qUj8ws1Q+I809UEcOpeA0jnHv+nYr/qrGPhIsX/cRwkQq3PPzMcz0Lh nLjjbJEJDQPlwGIFCIGzqph8cMIFgsYObK/ElxO2k3Xu/b97qyNeTHfSYyr1pJ36Zp NuTnGw66+YttBV8MvlN9/H1U24Ah3E+Z0mSD63U0= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 4578CF80143; Tue, 21 Apr 2020 21:31:57 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id BF350F801EC; Tue, 21 Apr 2020 21:31:54 +0200 (CEST) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id DD4B9F800E7 for ; Tue, 21 Apr 2020 21:31:47 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz DD4B9F800E7 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 3642EAE48; Tue, 21 Apr 2020 19:31:46 +0000 (UTC) Date: Tue, 21 Apr 2020 21:31:46 +0200 Message-ID: From: Takashi Iwai To: Alexander Tsoy Subject: Re: [PATCH] ALSA: usb-audio: Apply async workaround for Scarlett 2i4 2nd gen In-Reply-To: <20200421190908.462860-1-alexander@tsoy.me> References: <20200421190908.462860-1-alexander@tsoy.me> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue, 21 Apr 2020 21:09:08 +0200, Alexander Tsoy wrote: > > Due to rounding error driver sometimes incorrectly calculate next packet > size, which results in audible clicks on devices with synchronous playback > endpoints. For example on a high speed bus and a sample rate 44.1 kHz it > loses one sample every ~40.9 seconds. Fortunately playback interface on > Scarlett 2i4 2nd gen has a working explicit feedback endpoint, so we can > switch playback data endpoint to asynchronous mode as a workaround. > > Signed-off-by: Alexander Tsoy Applied now, thanks. I wonder, though, whether we can correct the rounding error in the driver code, too. Takashi > --- > sound/usb/quirks.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c > index 6c2dfd3bfcbf..351ba214a9d3 100644 > --- a/sound/usb/quirks.c > +++ b/sound/usb/quirks.c > @@ -1806,6 +1806,7 @@ void snd_usb_audioformat_attributes_quirk(struct snd_usb_audio *chip, > */ > fp->attributes &= ~UAC_EP_CS_ATTR_FILL_MAX; > break; > + case USB_ID(0x1235, 0x8200): /* Focusrite Scarlett 2i4 2nd gen */ > case USB_ID(0x1235, 0x8202): /* Focusrite Scarlett 2i2 2nd gen */ > case USB_ID(0x1235, 0x8205): /* Focusrite Scarlett Solo 2nd gen */ > /* > -- > 2.25.3 >