From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96228C2D0DB for ; Mon, 20 Jan 2020 16:50:13 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4592E2073D for ; Mon, 20 Jan 2020 16:50:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="SU04Q3ZS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4592E2073D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id B4B801667; Mon, 20 Jan 2020 17:49:20 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz B4B801667 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1579539010; bh=qOKjiwkaUHXeHaCZCXbuhTSItYYvuo+qsBlJLDTnXzs=; h=Date:From:To:In-Reply-To:References:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=SU04Q3ZSlKlbek4uttYnd+t3pcI7TpF+ZiilVOHRc8XZWxwsRq9lp4pkj4PhbSkzT Kows8bpMyVcv+fU4aJhfqtO24Iw1nlFTQ41dqtokaxY8Fuc0X07XRlrtWyLzct8TGd gohgYlZW7CeHJbQeHhNoRORGCSrJ1rJapePBrMrI= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 24AD0F801D8; Mon, 20 Jan 2020 17:49:20 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id D1849F8020C; Mon, 20 Jan 2020 17:49:18 +0100 (CET) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id DF2A3F800C6 for ; Mon, 20 Jan 2020 17:49:13 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz DF2A3F800C6 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id BA46FABB3; Mon, 20 Jan 2020 16:49:12 +0000 (UTC) Date: Mon, 20 Jan 2020 17:49:12 +0100 Message-ID: From: Takashi Iwai To: Kai Vehmanen In-Reply-To: <20200120160117.29130-4-kai.vehmanen@linux.intel.com> References: <20200120160117.29130-1-kai.vehmanen@linux.intel.com> <20200120160117.29130-4-kai.vehmanen@linux.intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Cc: cujomalainey@chromium.org, alsa-devel@alsa-project.org, broonie@kernel.org, pierre-louis.bossart@linux.intel.com Subject: Re: [alsa-devel] [PATCH v2 3/3] ALSA: hda/hdmi - add retry logic to parse_intel_hdmi() X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Mon, 20 Jan 2020 17:01:17 +0100, Kai Vehmanen wrote: > > The initial snd_hda_get_sub_node() can fail on certain > devices (e.g. some Chromebook models using Intel GLK). > The failure rate is very low, but as this is is part of > the probe process, end-user impact is high. > > In observed cases, related hardware status registers have > expected values, but the node query still fails. Retrying > the node query does seem to help, so fix the problem by > adding retry logic to the query. This does not impact > non-Intel platforms. > > BugLink: https://github.com/thesofproject/linux/issues/1642 > Signed-off-by: Kai Vehmanen > Reviewed-by: Takashi Iwai It seems that this felt out of Mark's hands, so I picked up now to my tree, as this doesn't seem depending on other changes. Now applied to for-next branch. thanks, Takashi > --- > sound/pci/hda/patch_hdmi.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c > index 630b1f5c276d..a4b75a9dfe3b 100644 > --- a/sound/pci/hda/patch_hdmi.c > +++ b/sound/pci/hda/patch_hdmi.c > @@ -2830,9 +2830,12 @@ static int alloc_intel_hdmi(struct hda_codec *codec) > /* parse and post-process for Intel codecs */ > static int parse_intel_hdmi(struct hda_codec *codec) > { > - int err; > + int err, retries = 3; > + > + do { > + err = hdmi_parse_codec(codec); > + } while (err < 0 && retries--); > > - err = hdmi_parse_codec(codec); > if (err < 0) { > generic_spec_free(codec); > return err; > -- > 2.17.1 > _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel