From: Takashi Iwai <tiwai@suse.de>
To: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Cc: alsa-devel@alsa-project.org, clemens@ladisch.de,
ffado-devel@lists.sf.net
Subject: Re: [PATCH 2/2] ALSA: oxfw: discontinue MIDI substream for scs1x at transaction failure
Date: Fri, 19 Feb 2016 09:19:46 +0100 [thread overview]
Message-ID: <s5hpovt1599.wl-tiwai@suse.de> (raw)
In-Reply-To: <1455843350-10156-3-git-send-email-o-takashi@sakamocchi.jp>
On Fri, 19 Feb 2016 01:55:50 +0100,
Takashi Sakamoto wrote:
>
> With a previous commit, ALSA oxfw driver retries transferring MIDI
> messages at transaction failure for scs1x. On the other hand, there're
> fatal transaction error. Then, MIDI messages never reach to the unit
> anymore. In this case, MIDI substream should be discontinued.
>
> This commit stops MIDI transferring after the fatal error occurs.
> Unfortunately, unlike ALSA PCM functionality, ALSA rawmidi core has no
> feature to discontinue MIDI substream in kernel side, thus this commit
> just stops MIDI transferring without notifying it to userspace.
It's fine to take this, and I would take it as is for now.
But we can extend the rawmidi somehow to deal with such an error, too.
Maybe just having "error" flag in the rawmidi runtime and adding a
helper function to set the error and stop the stream should work
easily.
thanks,
Takashi
next prev parent reply other threads:[~2016-02-19 8:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-19 0:55 [PATCH 0/2] ALSA: oxfw: implement retries for scs1x at transaction failure Takashi Sakamoto
2016-02-19 0:55 ` [PATCH 1/2] ALSA: oxfw: retry MIDI transferring " Takashi Sakamoto
2016-02-19 0:55 ` [PATCH 2/2] ALSA: oxfw: discontinue MIDI substream " Takashi Sakamoto
2016-02-19 8:19 ` Takashi Iwai [this message]
2016-02-19 9:23 ` Takashi Sakamoto
2016-02-19 9:46 ` Takashi Iwai
2016-02-19 15:51 ` Takashi Sakamoto
2016-02-19 16:04 ` Takashi Iwai
2016-02-19 16:11 ` Takashi Iwai
2016-02-19 16:19 ` Takashi Sakamoto
2016-02-19 8:17 ` [PATCH 0/2] ALSA: oxfw: implement retries " Takashi Iwai
2016-02-19 8:51 ` Takashi Sakamoto
-- strict thread matches above, loose matches on Subject: below --
2016-02-24 0:26 [PATCH 0/2 v2] " Takashi Sakamoto
2016-02-24 0:26 ` [PATCH 2/2] ALSA: oxfw: discontinue MIDI substream " Takashi Sakamoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hpovt1599.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=clemens@ladisch.de \
--cc=ffado-devel@lists.sf.net \
--cc=o-takashi@sakamocchi.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.