All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Vinod Koul <vinod.koul@intel.com>
Cc: liam.r.girdwood@linux.intel.com, alsa-devel@alsa-project.org,
	broonie@kernel.org
Subject: Re: [PATCH 2/2] ASoC: intel - use SNDRV_CTL_ELEM_ID_NAME_MAXLEN
Date: Sat, 18 Apr 2015 09:03:10 +0200	[thread overview]
Message-ID: <s5hpp71x6j5.wl-tiwai@suse.de> (raw)
In-Reply-To: <1429291413-30668-2-git-send-email-vinod.koul@intel.com>

At Fri, 17 Apr 2015 22:53:33 +0530,
Vinod Koul wrote:
> 
> we have defined SNDRV_CTL_ELEM_ID_NAME_MAXLEN as size of name array so use
> this define instead of numeric value
> 
> Signed-off-by: Vinod Koul <vinod.koul@intel.com>

I leave this to Mark.


thanks,

Takashi

> ---
>  sound/soc/intel/atom/sst-atom-controls.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/intel/atom/sst-atom-controls.h b/sound/soc/intel/atom/sst-atom-controls.h
> index daecc58f28af..c55f76a535b3 100644
> --- a/sound/soc/intel/atom/sst-atom-controls.h
> +++ b/sound/soc/intel/atom/sst-atom-controls.h
> @@ -695,7 +695,7 @@ struct sst_gain_mixer_control {
>  	u16 module_id;
>  	u16 pipe_id;
>  	u16 task_id;
> -	char pname[44];
> +	char pname[SNDRV_CTL_ELEM_ID_NAME_MAXLEN];
>  	struct snd_soc_dapm_widget *w;
>  };
>  
> -- 
> 1.7.9.5
> 

  reply	other threads:[~2015-04-18  7:03 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-17 17:23 [PATCH 1/2] ALSA: asound.h - use SNDRV_CTL_ELEM_ID_NAME_MAXLEN Vinod Koul
2015-04-17 17:23 ` [PATCH 2/2] ASoC: intel " Vinod Koul
2015-04-18  7:03   ` Takashi Iwai [this message]
2015-04-18 11:59   ` Mark Brown
2015-04-18  7:02 ` [PATCH 1/2] ALSA: asound.h " Takashi Iwai
2015-04-19  4:55 ` Takashi Sakamoto
2015-04-21 10:52   ` Takashi Iwai
2015-04-21 14:46     ` Pierre-Louis Bossart
2015-04-21 14:49       ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hpp71x6j5.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=liam.r.girdwood@linux.intel.com \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.