All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org, Anthony Liguori <aliguori@amazon.com>,
	Cole Robinson <crobinso@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 4/4] gtk: Add "Grab On Click" option
Date: Mon, 07 Apr 2014 10:21:17 +0200	[thread overview]
Message-ID: <s5hppktmtxe.wl%tiwai@suse.de> (raw)
In-Reply-To: <1396858063.5001.49.camel@nilsson.home.kraxel.org>

At Mon, 07 Apr 2014 10:07:43 +0200,
Gerd Hoffmann wrote:
> 
> On Fr, 2014-04-04 at 12:41 +0200, Takashi Iwai wrote:
> > I simply like it better, you don't? :)
> 
> I still think we should make this simply depend on absolute/relative
> pointer mode instead of asking the user to switch it manually.

Yes, agreed, it's more intuitive.
OTOH, we still want the explicit input grab in absolute mode.  So,
we'll need two flags in the end, the explicit grab by menu or key
combo, and the implicit grab by click in relative mode.

> I'll quickly go put patches 1-3 into a 2.0 pull request, so debating
> patch #4 doesn't stop the clear improvements from entering the tree.

Thanks!


Takashi

  reply	other threads:[~2014-04-07  8:21 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-04 10:41 [Qemu-devel] [PATCH v3 0/4] Fix relative pointer tracking on Gtk UI Takashi Iwai
2014-04-04 10:41 ` [Qemu-devel] [PATCH v3 1/4] gtk: Use gtk generic event signal instead of motion-notify-event Takashi Iwai
2014-04-04 10:41 ` [Qemu-devel] [PATCH v3 2/4] gtk: Fix the relative pointer tracking mode Takashi Iwai
2014-04-04 10:41 ` [Qemu-devel] [PATCH v3 3/4] gtk: Remember the last grabbed pointer position Takashi Iwai
2014-04-04 10:41 ` [Qemu-devel] [PATCH v3 4/4] gtk: Add "Grab On Click" option Takashi Iwai
2014-04-07  8:07   ` Gerd Hoffmann
2014-04-07  8:21     ` Takashi Iwai [this message]
2014-04-07 20:38     ` Michael S. Tsirkin
2014-04-08  6:25       ` Gerd Hoffmann
2014-04-08  8:11         ` Michael S. Tsirkin
2014-04-08  8:49           ` Gerd Hoffmann
2014-04-08  8:57             ` Michael S. Tsirkin
2014-04-08  9:23               ` Takashi Iwai
2014-04-04 23:08 ` [Qemu-devel] [PATCH v3 0/4] Fix relative pointer tracking on Gtk UI Brian Jackson
2014-04-06 10:36 ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hppktmtxe.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=aliguori@amazon.com \
    --cc=crobinso@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.