From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH 1/2] Version-check libtool correctly when doing an out-of-tree build Date: Sun, 17 Oct 2010 11:05:59 +0200 Message-ID: References: <20101008080629.GA11076@reptile.pseudorandom.co.uk> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.suse.de (cantor.suse.de [195.135.220.2]) by alsa0.perex.cz (Postfix) with ESMTP id 31C7F243E2 for ; Sun, 17 Oct 2010 11:06:00 +0200 (CEST) In-Reply-To: <20101008080629.GA11076@reptile.pseudorandom.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Simon McVittie Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org At Fri, 8 Oct 2010 09:06:29 +0100, Simon McVittie wrote: > > libtool is only created at the end of ./configure, so it doesn't make > sense to grep it in ./configure (the check would always fail the first > time). However, ltmain.sh is copied into the ${srcdir} by libtoolize and > should be safe to check at any time that configure can be run. > > Signed-off-by: Simon McVittie Applied now. Thanks. Takashi > --- > configure.in | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/configure.in b/configure.in > index abc4687..e904956 100644 > --- a/configure.in > +++ b/configure.in > @@ -115,7 +115,7 @@ AC_ARG_WITH(versioned, > versioned="$withval", versioned="yes") > if test "$versioned" = "yes"; then > # it seems that GNU ld versions since 2.10 are not broken > - xres=`grep '^VERSION=' libtool | cut -d = -f 2 | cut -d \" -f 2` > + xres=`grep '^VERSION=' ${srcdir}/ltmain.sh | cut -d = -f 2 | cut -d \" -f 2` > major=`echo $xres | cut -d . -f 1` > minor=`echo $xres | cut -d . -f 2` > pass=0 > -- > 1.7.1 > > [1.2 Digital signature ] > > [2 ] > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel