From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH] hda: Add GPIO mute support to STAC9205
Date: Mon, 28 Jan 2008 15:57:04 +0100
Message-ID: <s5hprvm577j.wl%tiwai@suse.de>
References: <479DEB20.70302@embeddedalley.com>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from mx1.suse.de (ns.suse.de [195.135.220.2])
	by alsa0.perex.cz (Postfix) with ESMTP id 873BF24637
	for <alsa-devel@alsa-project.org>; Mon, 28 Jan 2008 15:57:09 +0100 (CET)
In-Reply-To: <479DEB20.70302@embeddedalley.com>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Sender: alsa-devel-bounces@alsa-project.org
Errors-To: alsa-devel-bounces@alsa-project.org
To: Matthew Ranostay <mranostay@embeddedalley.com>
Cc: alsa-devel@alsa-project.org, Matt Porter <mporter@embeddedalley.com>, "Tellman, Steven" <Steven.Tellman@idt.com>
List-Id: alsa-devel@alsa-project.org

At Mon, 28 Jan 2008 09:48:00 -0500,
Matthew Ranostay wrote:
> 
> Support added for detecting HP jack presence via GPIO on several laptop docks.
> 
> Signed-off-by: Matthew Ranostay <mranostay@embeddedalley.com>
> ---
> diff -r b0d97ac73e0f pci/hda/patch_sigmatel.c
> --- a/pci/hda/patch_sigmatel.c	Fri Jan 25 15:24:50 2008 +0100
> +++ b/pci/hda/patch_sigmatel.c	Mon Jan 28 09:34:16 2008 -0500
> @@ -122,7 +122,9 @@ struct sigmatel_spec {
>  	unsigned int alt_switch: 1;
>  	unsigned int hp_detect: 1;
>  
> -	unsigned int gpio_mask, gpio_data;
> +	unsigned int gpio_en_mask, gpio_dir_mask;
> +	unsigned int gpio_data;
> +	unsigned int gpio_mute;

The mask is valid for both dir and data bits.  So I'd like to have the
following four fields:

	unsigned int gpio_mask;
	unsigned int gpio_dir;
	unsigned int gpio_data;
	unsigned int gpio_mute;

(Actually they could be unsigned char on HD-audio.)

Otherwise the patch looks good.


thanks,

Takashi