From: Takashi Iwai <tiwai@suse.de>
To: Liam Girdwood <liam.girdwood@wolfsonmicro.com>
Cc: alsa-devel <alsa-devel@lists.sourceforge.net>
Subject: Re: [PATCH 1/5] ASoC: Build files
Date: Tue, 19 Sep 2006 14:20:08 +0200 [thread overview]
Message-ID: <s5hpsdshwuf.wl%tiwai@suse.de> (raw)
In-Reply-To: <1158326252.22950.64.camel@localhost.localdomain>
At Fri, 15 Sep 2006 14:17:32 +0100,
Liam Girdwood wrote:
>
> Index: alsa-kernel/soc/Kconfig
> ===================================================================
> --- /dev/null
> +++ alsa-kernel/soc/Kconfig
> @@ -0,0 +1,18 @@
> +#
> +# SoC audio configuration
> +#
> +
> +menu "SoC audio support"
> +
> +config SND_SOC
> + tristate "SoC audio support"
Don't you need dependencies?
Also, changes for Kconfig and Makefile are usually the last patch so
that you don't break build. A minor issue, though...
Takashi
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
next prev parent reply other threads:[~2006-09-19 12:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-15 13:17 [PATCH 1/5] ASoC: Build files Liam Girdwood
2006-09-19 12:20 ` Takashi Iwai [this message]
2006-09-22 16:56 ` Liam Girdwood
2006-09-29 12:01 ` Takashi Iwai
2006-09-29 13:56 ` Liam Girdwood
2006-09-29 14:47 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hpsdshwuf.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@lists.sourceforge.net \
--cc=liam.girdwood@wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.