Re: Re: [PATCH] asihpi update

[Takashi Iwai <tiwai@suse.de>]

At Sat, 19 Nov 2005 01:21:37 +1300,
Delio Brignoli wrote:
> 
> 
> Hello Takashi,
> 
> Takashi Iwai wrote:
> > OK, my concern was the change of alsa-driver/asihpi/Makefile in your
> > last patch.  You added the stuff to generate at compile time there.
> > I'm not against at all to process it _manually_ on your side.
> 
> The extra rules in the makefile are to be used by us internally to 
> prepare dist files (and are only triggered when source files are 
> missing) or by customers that want to compile ALSA with bleeding edge 
> code from our CVS rep.

Then please provide a separate script to do that, instead of merging
to Makefile.  (In addition, embedding the directory path is not good,
too.  You can mangle it via configure script if necessary.)

> I'm not 100% sure about what you mean with "_manually_".
> if you mean that: I generate code for an ALSA dist from our CVS, then 
> diff, send the patch to alsa-devel. Then it's fine. :)

Yes, I meant it exactly.  Basically, the alsa-driver tree should be
self-consistent except for kernel source and chain tools.

If you need to update the driver codes, just give us the patches.
Of course, you can put a script to generate such cdes for help to
someone else into the public tree, but it shouldn't be called
unconditionally.


thanks,

Takashi


-------------------------------------------------------
This SF.Net email is sponsored by the JBoss Inc.  Get Certified Today
Register for a JBoss Training Course.  Free Certification Exam
for All Training Attendees Through End of 2005. For more info visit:
http://ads.osdn.com/?ad_id=7628&alloc_id=16845&op=click