From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: Coding style: bit fields Date: Tue, 08 Mar 2005 16:47:08 +0100 Message-ID: References: <20050219183726.5d76f588.pochini@shiny.it> <20050226195918.0a87bc8f.pochini@shiny.it> Mime-Version: 1.0 (generated by SEMI 1.14.5 - "Awara-Onsen") Content-Type: text/plain; charset=US-ASCII In-Reply-To: <20050226195918.0a87bc8f.pochini@shiny.it> Sender: alsa-devel-admin@lists.sourceforge.net Errors-To: alsa-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: To: Giuliano Pochini Cc: alsa-devel@lists.sourceforge.net List-Id: alsa-devel@alsa-project.org At Sat, 26 Feb 2005 19:59:18 +0100, Giuliano Pochini wrote: > > On Tue, 22 Feb 2005 22:04:08 +0100 > Takashi Iwai wrote: > > > At Sat, 19 Feb 2005 18:37:26 +0100, > > Giuliano Pochini wrote: > > > > > > The echoaudio driver has many flags in chip_t stored as bit fields. It > > > doesn't save any space because accessing a bitfield requires more > > > instructions than accessing a byte. Eg. ppc needs one instruction to write a > > > char and three instructions to write a bitfield (load, modify, store, 12 > > > bytes...). I'm thinking about replacing all af them with chars. Is it ok ? > > > > Sure, go ahead! > > Fine. > > > Signed-off-by: Giuliano Pochini Thanks, now it's on CVS. Takashi ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click