From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: STAC9758 questions Date: Tue, 29 Jun 2004 18:30:03 +0200 Sender: alsa-devel-admin@lists.sourceforge.net Message-ID: References: <200406291025.i5TAPWAQ027313@www4.pobox.sk> Mime-Version: 1.0 (generated by SEMI 1.14.5 - "Awara-Onsen") Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: <200406291025.i5TAPWAQ027313@www4.pobox.sk> Errors-To: alsa-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: To: Peter Zubaj Cc: alsa-devel@lists.sourceforge.net List-Id: alsa-devel@alsa-project.org At Tue, 29 Jun 2004 12:25:32 +0200, Peter Zubaj wrote: > > Hi, > > In file alsa-driver/alsa-kernel/pci/ac97_patch.c > in function > snd_ac97_stac9758_output_jack_put > > there is > up(&ac97->mutex); > but not > down(&ac97->mutex); > is this good (why not remove up(&ac97->mutex);)???? > > also > in function snd_ac97_stac9758_input_jack_put id used > ac97_update_bits_page, but in function > snd_ac97_stac9758_output_jack_put is only used function > snd_ac97_update_bits to set value. > Why both functions not use function ac97_update_bits_page to set value > ??? you're right :) fixed on cvs now. thanks, Takashi ------------------------------------------------------- This SF.Net email sponsored by Black Hat Briefings & Training. Attend Black Hat Briefings & Training, Las Vegas July 24-29 - digital self defense, top technical experts, no vendor pitches, unmatched networking opportunities. Visit www.blackhat.com