From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+willy=40w.ods.org@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S272568AbTHMNCr (ORCPT <rfc822;willy@w.ods.org>);
	Wed, 13 Aug 2003 09:02:47 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S272555AbTHMNCq
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Wed, 13 Aug 2003 09:02:46 -0400
Received: from mail.suse.de ([213.95.15.193]:42766 "EHLO Cantor.suse.de")
	by vger.kernel.org with ESMTP id S272389AbTHMNCo (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 13 Aug 2003 09:02:44 -0400
Date: Wed, 13 Aug 2003 15:01:30 +0200
Message-ID: <s5hptj9u2xh.wl@alsa2.suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Andrew Morton <akpm@osdl.org>
Cc: Felipe Alfaro Solana <felipe_alfaro@linuxmail.org>,
       linux-kernel@vger.kernel.org, zwane@commfireservices.com,
       linux-sound@vger.kernel.org
Subject: Re: OPL3SA2: spin_is_locked on uninitialized spinlock
In-Reply-To: <20030813050448.221aaa49.akpm@osdl.org>
References: <1060774796.3518.4.camel@teapot.felipe-alfaro.com>
	<20030813050448.221aaa49.akpm@osdl.org>
User-Agent: Wanderlust/2.6.1 (Upside Down) SEMI/1.14.4 (Hosorogi)
 FLIM/1.14.4 (=?ISO-8859-4?Q?Kashiharajing=FE-mae?=) APEL/10.2 MULE
 XEmacs/21.4 (patch 12) (Portable Code) (i386-suse-linux)
MIME-Version: 1.0 (generated by SEMI 1.14.4 - "Hosorogi")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org

At Wed, 13 Aug 2003 05:04:48 -0700,
Andrew Morton wrote:
> 
> Felipe Alfaro Solana <felipe_alfaro@linuxmail.org> wrote:
> >
> > I've found a lot of errors like this when loading the OPL3SA2 sound
> >  driver on my old Intel AL440LX computer, running 2.6.0-test3-mm1:
> > 
> >  sound/isa/opl3sa2.c:204: spin_is_locked on uninitialized spinlock
> >  d6200034.
> 
> Does this help?
> 
> diff -puN sound/isa/opl3sa2.c~opl3sa2-lock-init-fix sound/isa/opl3sa2.c
> --- 25/sound/isa/opl3sa2.c~opl3sa2-lock-init-fix	2003-08-13 05:03:32.000000000 -0700
> +++ 25-akpm/sound/isa/opl3sa2.c	2003-08-13 05:04:06.000000000 -0700
> @@ -752,6 +752,7 @@ static int __devinit snd_opl3sa2_probe(i
>  		err = -ENOMEM;
>  		goto __error;
>  	}
> +	spin_lock_init(&chip->reg_lock);
>  	chip->irq = -1;
>  	if ((err = snd_device_new(card, SNDRV_DEV_LOWLEVEL, chip, &ops)) < 0)
>  		goto __error;

oh yeah this one should fix.  thanks.

-- 
Takashi Iwai <tiwai@suse.de>		SuSE Linux AG - www.suse.de
ALSA Developer				ALSA Project - www.alsa-project.org