From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: EMU10K1 - CVS: nasty "click" at end of WAV files, and spurious extra modules. Date: Thu, 30 Jan 2003 10:35:40 +0100 Sender: alsa-devel-admin@lists.sourceforge.net Message-ID: References: <20030130001100.60428.qmail@web40603.mail.yahoo.com> Mime-Version: 1.0 (generated by SEMI 1.14.4 - "Hosorogi") Content-Type: multipart/mixed; boundary="Multipart_Thu_Jan_30_10:35:40_2003-1" Return-path: In-Reply-To: <20030130001100.60428.qmail@web40603.mail.yahoo.com> Errors-To: alsa-devel-admin@lists.sourceforge.net List-Help: List-Post: List-Subscribe: , List-Unsubscribe: , List-Archive: To: Chris Rankin Cc: alsa-devel@lists.sourceforge.net List-Id: alsa-devel@alsa-project.org --Multipart_Thu_Jan_30_10:35:40_2003-1 Content-Type: text/plain; charset=US-ASCII At Thu, 30 Jan 2003 00:11:00 +0000 (GMT), Chris Rankin wrote: > > Hi, > > I have just installed the latest ALSA-CVS and I have > noticed a few oddities: > > First, these modules are suddenly being compiled. I > don't know why: > > snd-emu8000-synth.o > snd-gus-synth.o > snd-trident-synth.o because of the last changes of Makefiles... will be fixed soon. > More importantly, playing WAV files via my SB Live! > using aplay is making a nasty, loud "click" sound > right at the end. It didn't used to do this. Any idea > which change is causing it, please? does the attached patch have any influence? Takashi --Multipart_Thu_Jan_30_10:35:40_2003-1 Content-Type: application/octet-stream Content-Disposition: attachment; filename="sgbuf-clear.dif" Content-Transfer-Encoding: 7bit Index: alsa-driver/acore/pcm_sgbuf.c =================================================================== RCS file: /suse/tiwai/cvs/alsa/alsa-driver/acore/pcm_sgbuf.c,v retrieving revision 1.7 diff -u -r1.7 pcm_sgbuf.c --- alsa-driver/acore/pcm_sgbuf.c 27 Jan 2003 11:05:04 -0000 1.7 +++ alsa-driver/acore/pcm_sgbuf.c 30 Jan 2003 09:34:10 -0000 @@ -146,6 +146,7 @@ #endif } + memset(vmaddr, 0, size); return vmaddr; _failed: --Multipart_Thu_Jan_30_10:35:40_2003-1-- ------------------------------------------------------- This SF.NET email is sponsored by: SourceForge Enterprise Edition + IBM + LinuxWorld = Something 2 See! http://www.vasoftware.com