Re: minor bug in make-install target

[Takashi Iwai <tiwai@suse.de>]

[-- Attachment #1: Type: text/plain, Size: 2540 bytes --]

At Mon, 11 Feb 2002 15:27:11 +0100,
Jörn Nettingsmeier wrote:
> 
> Takashi Iwai wrote:
> > 
> > At Sun, 10 Feb 2002 12:59:12 +0100,
> > Jörn Nettingsmeier wrote:
> > >
> > > Takashi Iwai wrote:
> > > >
> > > > Hi,
> > > >
> > > > At Thu, 31 Jan 2002 10:53:24 +0100,
> > > > Jörn Nettingsmeier wrote:
> > > > >
> > > > > hello jaroslav !
> > > > >
> > > > > i just found a minor bug in the make install target of alsa-driver:
> > > > >
> > > > > on my system, /usr/src is a link to /data1/src (which is another
> > > > > disk).
> > > > >
> > > > > i have alsa sources on /usr/src/alsa-cvs/alsa-driver
> > > > >
> > > > > when i "make install" the kernel modules, i end up with
> > > > > /lib/modules/<version>/kernel/sound/data1/src/alsa-cvs/alsa-driver/{acore,pci,synth}
> > > > >
> > > > > is it possible to fix the script so that it uses the correct paths
> > > > > even when it's a link ?
> > > > >
> > > > > btw, i also tried a relative link (src -> ../data/src), but the
> > > > > problem remains.
> > > > >
> > > > > moving the module tree by hand works for me, and it might not be
> > > > > worth fixing when the stuff goes into the kernel anyway, but i
> > > > > thought you might want to know.
> > > >
> > > > I fixed on cvs.
> > > >
> > > > now Rules.make guesses the destination directory from TREETOPDIR
> > > > variable, which is exported from the toplevel Makefile, so that TOPDIR
> > > > defined in each sub directory doesn't matter.
> > > >
> > > > this mechanism seems working at least on my system.
> > > > please give a try.
> > >
> > > hi takashi !
> > >
> > > sorry for the long delay. i have just checked out alsa-cvs again,
> > > and the problem remains.
> > > i still get
> > > /lib/modules/2.4.18-pre9/kernel/sound/data1/src/alsa-cvs/alsa-driver/{pci,acore,synth}
> > 
> > please check whether your MAINSRCDIR is defined in Makefile.conf
> > correctly, in your case, /data1/src/alsa-cvs/alsa-driver.
> > the latest Rules.make reduces the path name according to this
> > variable.  it's possbile that the path name is different due to
> > symlinks..
> 
> i have
> mainsrcdir      = .
> MAINSRCDIR      = /usr/src/alsa-cvs/alsa-driver
> 
> that's probably because i go to that directory via cd
> /usr/src/alsa-cvs/alsa-driver.
> how come the makefile ever knows we are in /data1/src ?
> pwd reports /usr/...

is /data1/src is symlinked to /usr/src?
what says /bin/pwd instead of built-in pwd?

if this inconsistency really comes from the different pwd's, then the
attached patch might solve the problem...



Takashi

[-- Attachment #2: pwd-fix.dif --]
[-- Type: application/octet-stream, Size: 497 bytes --]

Index: alsa-driver/configure.in
===================================================================
RCS file: /suse/tiwai/cvs/alsa/alsa-driver/configure.in,v
retrieving revision 1.53
diff -u -r1.53 configure.in
--- alsa-driver/configure.in	4 Feb 2002 13:46:40 -0000	1.53
+++ alsa-driver/configure.in	11 Feb 2002 15:04:24 -0000
@@ -27,7 +27,7 @@
 
 dnl Check for current directory
 AC_MSG_CHECKING(for current directory)
-SRCDIR=`pwd`
+SRCDIR=`/bin/pwd`
 AC_SUBST(SRCDIR)
 AC_MSG_RESULT($SRCDIR)