From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4ED42C433F5 for ; Thu, 10 Mar 2022 16:44:35 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 547041937; Thu, 10 Mar 2022 17:43:43 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 547041937 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1646930673; bh=3PNYyeDEuHvmQPBowd0JmZDI+SJXtCxIyRKaVOKfVy8=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=SkK2VHMAJVjT4YmmZGqk6YxzMvFYOa5zAdd0qQuABmyb3e5TX/m8CON3S1Qx9ePA0 bPR2ZtflowOEDn8iDtshIy+eZ94mjNoGumCJW1C0D9GZbO4MEa3/8zNpaA4XJKHA/r TzDsSKMVJZUm3VOyZPK+NgFTlJ3No1Rshx3AbPbs= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 8A15EF8012F; Thu, 10 Mar 2022 17:43:42 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 9C479F80137; Thu, 10 Mar 2022 17:43:40 +0100 (CET) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id B0360F800D2 for ; Thu, 10 Mar 2022 17:43:34 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz B0360F800D2 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="cY023Umq"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="40vsb5FF" Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 756EC210EA; Thu, 10 Mar 2022 16:43:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1646930613; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CfWTQ9Km/5hHkadU1tbVWmLbyv68E1sgDwmk1Bhavnk=; b=cY023Umq11EXNUkC5SE5hjXY41RwZkt83+eaqLKqmnXxg0ftLk0J0ZavrurikmrXAomcg7 8wb8oDxdz8RbaraZ2Cl7aZraKysFLZjsyqfg6wkh6Hbmd69n0hu5TRd2U8gLA4GLt2o/lD kq4Rkrr0fsNUxRuSVkYZp+rEv+MeUbE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1646930613; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CfWTQ9Km/5hHkadU1tbVWmLbyv68E1sgDwmk1Bhavnk=; b=40vsb5FFN6mjH+8Tsu0PCDwegncjAafkCJvtI5xvB9fC2NysO8lpVViCRanlqrtyoEc4g1 KFqUAFGZBhifHkDA== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 5BDC8A3B88; Thu, 10 Mar 2022 16:43:33 +0000 (UTC) Date: Thu, 10 Mar 2022 17:43:33 +0100 Message-ID: From: Takashi Iwai To: Subject: Re: [PATCH v3 01/16] sound: cs35l41: Unify hardware configuration In-Reply-To: References: <20220308171730.454587-1-tanureal@opensource.cirrus.com> <20220308171730.454587-2-tanureal@opensource.cirrus.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, Charles Keepax , patches@opensource.cirrus.com, Takashi Iwai , Rob Herring , Liam Girdwood , Mark Brown , linux-kernel@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, 10 Mar 2022 17:40:45 +0100, wrote: > > On 3/10/22 1:44 PM, Takashi Iwai wrote: > > On Tue, 08 Mar 2022 18:17:15 +0100, > > Lucas Tanure wrote: > > > +enum cs35l41_gpio_func { > > > + CS35L41_HIZ, > > > + CS35L41_GPIO, > > > + CS35L41_INT_OPEN_DRAIN_GPIO2, > > > + CS35L41_MCLK, > > > + CS35L41_INT_PUSH_PULL_LOW_GPIO2, > > > + CS35L41_INT_PUSH_PULL_HIGH_GPIO2, > > > + CS35L41_PDM_CLK_GPIO2, > > > + CS35L41_PDM_DATA_GPIO2, > > > + CS35L41_MDSYNC_GPIO1 = 2, > > > + CS35L41_PDM_CLK_GPIO1 = 4, > > > + CS35L41_PDM_DATA_GPIO1 = 5, > > > }; > > > > So CS35L41_MDSYNC_GPIO1 is identical with *_DRAIN_GPIO2, i.e. it's an > > alias? > > > > > > thanks, > > > > Takashi > > > > The value 2 sets GPIO1 as MDSYNC pin and GPIO2 as IRQ pin (Open drain). > It could be the same label, like CS35L41_GPIO1_MDSYNC_GPIO2_IRQ, but I think separating them is better for understanding the code and organizing the code. Yes, separating GPIO1 and GPIO2 would be less confusing. thanks, Takashi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8067BC433F5 for ; Thu, 10 Mar 2022 16:43:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242635AbiCJQog (ORCPT ); Thu, 10 Mar 2022 11:44:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47982 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240945AbiCJQof (ORCPT ); Thu, 10 Mar 2022 11:44:35 -0500 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BB7A6159297; Thu, 10 Mar 2022 08:43:34 -0800 (PST) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 756EC210EA; Thu, 10 Mar 2022 16:43:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1646930613; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CfWTQ9Km/5hHkadU1tbVWmLbyv68E1sgDwmk1Bhavnk=; b=cY023Umq11EXNUkC5SE5hjXY41RwZkt83+eaqLKqmnXxg0ftLk0J0ZavrurikmrXAomcg7 8wb8oDxdz8RbaraZ2Cl7aZraKysFLZjsyqfg6wkh6Hbmd69n0hu5TRd2U8gLA4GLt2o/lD kq4Rkrr0fsNUxRuSVkYZp+rEv+MeUbE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1646930613; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CfWTQ9Km/5hHkadU1tbVWmLbyv68E1sgDwmk1Bhavnk=; b=40vsb5FFN6mjH+8Tsu0PCDwegncjAafkCJvtI5xvB9fC2NysO8lpVViCRanlqrtyoEc4g1 KFqUAFGZBhifHkDA== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 5BDC8A3B88; Thu, 10 Mar 2022 16:43:33 +0000 (UTC) Date: Thu, 10 Mar 2022 17:43:33 +0100 Message-ID: From: Takashi Iwai To: Cc: Liam Girdwood , Mark Brown , Rob Herring , Jaroslav Kysela , Takashi Iwai , , , , , Charles Keepax Subject: Re: [PATCH v3 01/16] sound: cs35l41: Unify hardware configuration In-Reply-To: References: <20220308171730.454587-1-tanureal@opensource.cirrus.com> <20220308171730.454587-2-tanureal@opensource.cirrus.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, 10 Mar 2022 17:40:45 +0100, wrote: > > On 3/10/22 1:44 PM, Takashi Iwai wrote: > > On Tue, 08 Mar 2022 18:17:15 +0100, > > Lucas Tanure wrote: > > > +enum cs35l41_gpio_func { > > > + CS35L41_HIZ, > > > + CS35L41_GPIO, > > > + CS35L41_INT_OPEN_DRAIN_GPIO2, > > > + CS35L41_MCLK, > > > + CS35L41_INT_PUSH_PULL_LOW_GPIO2, > > > + CS35L41_INT_PUSH_PULL_HIGH_GPIO2, > > > + CS35L41_PDM_CLK_GPIO2, > > > + CS35L41_PDM_DATA_GPIO2, > > > + CS35L41_MDSYNC_GPIO1 = 2, > > > + CS35L41_PDM_CLK_GPIO1 = 4, > > > + CS35L41_PDM_DATA_GPIO1 = 5, > > > }; > > > > So CS35L41_MDSYNC_GPIO1 is identical with *_DRAIN_GPIO2, i.e. it's an > > alias? > > > > > > thanks, > > > > Takashi > > > > The value 2 sets GPIO1 as MDSYNC pin and GPIO2 as IRQ pin (Open drain). > It could be the same label, like CS35L41_GPIO1_MDSYNC_GPIO2_IRQ, but I think separating them is better for understanding the code and organizing the code. Yes, separating GPIO1 and GPIO2 would be less confusing. thanks, Takashi