From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH 3/4] ALSA: hda: Log HDA Hardware related
	errors
Date: Tue, 15 May 2018 09:43:42 +0200
Message-ID: <s5hr2md4b4h.wl-tiwai@suse.de>
References: <1526366456-20470-1-git-send-email-sriramx.periyasamy@intel.com>
 <1526366456-20470-4-git-send-email-sriramx.periyasamy@intel.com>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from mx2.suse.de (mx2.suse.de [195.135.220.15])
 by alsa0.perex.cz (Postfix) with ESMTP id 2F152266F0F
 for <alsa-devel@alsa-project.org>; Tue, 15 May 2018 09:43:42 +0200 (CEST)
In-Reply-To: <1526366456-20470-4-git-send-email-sriramx.periyasamy@intel.com>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/options/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel/>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Errors-To: alsa-devel-bounces@alsa-project.org
Sender: alsa-devel-bounces@alsa-project.org
To: Sriram Periyasamy <sriramx.periyasamy@intel.com>
Cc: Liam Girdwood <liam.r.girdwood@linux.intel.com>, Patches Audio <patches.audio@intel.com>, ALSA ML <alsa-devel@alsa-project.org>, Mark Brown <broonie@kernel.org>, Pardha Saradhi K <pardha.saradhi.kesapragada@intel.com>
List-Id: alsa-devel@alsa-project.org

On Tue, 15 May 2018 08:40:55 +0200,
Sriram Periyasamy wrote:
> 
> From: Pardha Saradhi K <pardha.saradhi.kesapragada@intel.com>
> 
> Detect the timeout while modifying HDA DMA related Registers
> for stream reset and print them to console for user information
> 
> Signed-off-by: Pardha Saradhi K <pardha.saradhi.kesapragada@intel.com>
> Signed-off-by: Sriram Periyasamy <sriramx.periyasamy@intel.com>
> ---
>  sound/hda/hdac_stream.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/sound/hda/hdac_stream.c b/sound/hda/hdac_stream.c
> index 33c8ced528f6..aa8a2884289f 100644
> --- a/sound/hda/hdac_stream.c
> +++ b/sound/hda/hdac_stream.c
> @@ -144,6 +144,10 @@ void snd_hdac_stream_reset(struct hdac_stream *azx_dev)
>  		if (val)
>  			break;
>  	} while (--timeout);
> +
> +	if (!timeout)
> +		dev_err(azx_dev->bus->dev, "timeout on stream reset entry\n");
> +
>  	val &= ~SD_CTL_STREAM_RESET;
>  	snd_hdac_stream_writeb(azx_dev, SD_CTL, val);
>  	udelay(3);
> @@ -157,6 +161,9 @@ void snd_hdac_stream_reset(struct hdac_stream *azx_dev)
>  			break;
>  	} while (--timeout);
>  
> +	if (!timeout)
> +		dev_err(azx_dev->bus->dev, "timeout on stream reset exit\n");

Just from curiosity: did you ever hit these?  Or just because of
consistency?


Takashi