From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH] ALSA: declare snd_kcontrol_new structures as const Date: Tue, 30 May 2017 11:03:09 +0200 Message-ID: References: <1495896375-30855-1-git-send-email-bhumirks@gmail.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 68B44266AA1 for ; Tue, 30 May 2017 11:03:10 +0200 (CEST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Julia Lawall Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, clemens@ladisch.de, lgirdwood@gmail.com, broonie@kernel.org, johannes@sipsolutions.net, linuxppc-dev@lists.ozlabs.org, Bhumika Goyal List-Id: alsa-devel@alsa-project.org On Tue, 30 May 2017 10:56:39 +0200, Julia Lawall wrote: > > > > On Tue, 30 May 2017, Takashi Iwai wrote: > > > On Sat, 27 May 2017 16:46:15 +0200, > > Bhumika Goyal wrote: > > > > > > Declare snd_kcontrol_new structures as const as they are only passed an > > > argument to the function snd_ctl_new1. This argument is of type const, > > > so snd_kcontrol_new structures having this property can be made const. > > > Done using Coccinelle: > > > > > > @r disable optional_qualifier@ > > > identifier x; > > > position p; > > > @@ > > > static struct snd_kcontrol_new x@p={...}; > > > > > > @ok@ > > > identifier r.x; > > > position p; > > > @@ > > > snd_ctl_new1(&x@p,...) > > > > > > @bad@ > > > position p != {r.p,ok.p}; > > > identifier r.x; > > > @@ > > > x@p > > > > > > @depends on !bad disable optional_qualifier@ > > > identifier r.x; > > > @@ > > > +const > > > struct snd_kcontrol_new x; > > > > > > Cross compiled these files: > > > sound/aoa/codecs/tas.c - powerpc > > > sound/mips/{hal2.c/sgio2audio.c} - mips > > > sound/ppc/{awacs.c/beep.c/tumbler.c} - powerpc > > > sound/soc/sh/siu_dai.c - sh > > > Could not find an architecture to compile sound/sh/aica.c. > > > > > > Signed-off-by: Bhumika Goyal > > > > Applied now, as it looks safe enough. But I prefer splitting to > > individual patches, so please try to do that at the next time. > > Individual patches in a series? Yes. Takashi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3wcSLn1F3qzDq5x for ; Tue, 30 May 2017 19:03:13 +1000 (AEST) Date: Tue, 30 May 2017 11:03:09 +0200 Message-ID: From: Takashi Iwai To: Julia Lawall Cc: Bhumika Goyal , alsa-devel@alsa-project.org, lgirdwood@gmail.com, broonie@kernel.org, clemens@ladisch.de, linuxppc-dev@lists.ozlabs.org, perex@perex.cz, johannes@sipsolutions.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ALSA: declare snd_kcontrol_new structures as const In-Reply-To: References: <1495896375-30855-1-git-send-email-bhumirks@gmail.com> MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, 30 May 2017 10:56:39 +0200, Julia Lawall wrote: > > > > On Tue, 30 May 2017, Takashi Iwai wrote: > > > On Sat, 27 May 2017 16:46:15 +0200, > > Bhumika Goyal wrote: > > > > > > Declare snd_kcontrol_new structures as const as they are only passed an > > > argument to the function snd_ctl_new1. This argument is of type const, > > > so snd_kcontrol_new structures having this property can be made const. > > > Done using Coccinelle: > > > > > > @r disable optional_qualifier@ > > > identifier x; > > > position p; > > > @@ > > > static struct snd_kcontrol_new x@p={...}; > > > > > > @ok@ > > > identifier r.x; > > > position p; > > > @@ > > > snd_ctl_new1(&x@p,...) > > > > > > @bad@ > > > position p != {r.p,ok.p}; > > > identifier r.x; > > > @@ > > > x@p > > > > > > @depends on !bad disable optional_qualifier@ > > > identifier r.x; > > > @@ > > > +const > > > struct snd_kcontrol_new x; > > > > > > Cross compiled these files: > > > sound/aoa/codecs/tas.c - powerpc > > > sound/mips/{hal2.c/sgio2audio.c} - mips > > > sound/ppc/{awacs.c/beep.c/tumbler.c} - powerpc > > > sound/soc/sh/siu_dai.c - sh > > > Could not find an architecture to compile sound/sh/aica.c. > > > > > > Signed-off-by: Bhumika Goyal > > > > Applied now, as it looks safe enough. But I prefer splitting to > > individual patches, so please try to do that at the next time. > > Individual patches in a series? Yes. Takashi