All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Marcel Hasler <mahasler@gmail.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] snd-usb-audio: Add quirk for Syntek STK1160.
Date: Thu, 27 Oct 2016 12:16:56 +0200	[thread overview]
Message-ID: <s5hr372p04n.wl-tiwai@suse.de> (raw)
In-Reply-To: <20161026224227.GA7683@arch-desktop>

On Thu, 27 Oct 2016 00:42:27 +0200,
Marcel Hasler wrote:
> 
> The stk1160 chip needs QUIRK_AUDIO_ALIGN_TRANSFER. This patch resolves the issue reported on the
> mailing list (http://marc.info/?l=linux-sound&m=139223599126215&w=2) and also fixes bug 180071
> (https://bugzilla.kernel.org/show_bug.cgi?id=180071).
> 
> Signed-off-by: Marcel Hasler <mahasler@gmail.com>

Thanks, applied now, as the fix looks trivial.
But at the next, please put Cc to alsa-devel ML.


Takashi

> ---
>  sound/usb/quirks-table.h | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 
> diff --git a/sound/usb/quirks-table.h b/sound/usb/quirks-table.h
> index c60a776..8a59d47 100644
> --- a/sound/usb/quirks-table.h
> +++ b/sound/usb/quirks-table.h
> @@ -2907,6 +2907,23 @@ AU0828_DEVICE(0x2040, 0x7260, "Hauppauge", "HVR-950Q"),
>  AU0828_DEVICE(0x2040, 0x7213, "Hauppauge", "HVR-950Q"),
>  AU0828_DEVICE(0x2040, 0x7270, "Hauppauge", "HVR-950Q"),
>  
> +/* Syntek STK1160 */
> +{
> +	.match_flags = USB_DEVICE_ID_MATCH_DEVICE |
> +		       USB_DEVICE_ID_MATCH_INT_CLASS |
> +		       USB_DEVICE_ID_MATCH_INT_SUBCLASS,
> +	.idVendor = 0x05e1,
> +	.idProduct = 0x0408,
> +	.bInterfaceClass = USB_CLASS_AUDIO,
> +	.bInterfaceSubClass = USB_SUBCLASS_AUDIOCONTROL,
> +	.driver_info = (unsigned long) &(const struct snd_usb_audio_quirk) {
> +		.vendor_name = "Syntek",
> +		.product_name = "STK1160",
> +		.ifnum = QUIRK_ANY_INTERFACE,
> +		.type = QUIRK_AUDIO_ALIGN_TRANSFER
> +	}
> +},
> +
>  /* Digidesign Mbox */
>  {
>  	/* Thanks to Clemens Ladisch <clemens@ladisch.de> */
> -- 
> 2.10.1
> 
> 

       reply	other threads:[~2016-10-27 10:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20161026224227.GA7683@arch-desktop>
2016-10-27 10:16 ` Takashi Iwai [this message]
2016-10-27  8:13 [PATCH] snd-usb-audio: Add quirk for Syntek STK1160 Marcel Hasler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hr372p04n.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=mahasler@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.