From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: Request for test (1.0.18 final) Date: Tue, 28 Oct 2008 10:28:03 +0100 Message-ID: References: <4905F6EB.8080507@gmail.com> <4906C822.7070807@ladisch.de> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.suse.de (ns.suse.de [195.135.220.2]) by alsa0.perex.cz (Postfix) with ESMTP id 1845524131 for ; Tue, 28 Oct 2008 10:28:04 +0100 (CET) In-Reply-To: <4906C822.7070807@ladisch.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Clemens Ladisch Cc: ALSA development List-Id: alsa-devel@alsa-project.org At Tue, 28 Oct 2008 09:06:58 +0100, Clemens Ladisch wrote: > > Jaroslav Kysela wrote: > > Please, report compilation trouble with the current ALSA code. > > make[4]: *** No rule to make target `/home/c/alsa/alsa-driver/i2c/other/tea575x-tuner.o', needed by `/home/c/alsa/alsa-driver/i2c/other/snd-tea575x-tuner.o'. Stop. > make[3]: *** [/home/c/alsa/alsa-driver/i2c/other] Error 2 > make[2]: *** [/home/c/alsa/alsa-driver/i2c] Error 2 > make[1]: *** [_module_/home/c/alsa/alsa-driver] Error 2 > make[1]: Leaving directory `/root/linux-2.6' > make: *** [compile] Error 2 > > In my kernel, CONFIG_VIDEO_DEV is set but CONFIG_VIDEO_V4L1 isn't, > and the snd-tea575x-tuner module depends on the latter. > > I don't fully understand the purpose of the hack in the makefile, but > this patch works for me: IIRC, the hack was needed at the time alsa-driver's kconfig parser didn't parse the tea575x dependency correctly. So, the whole hack should be removed now. How about the patch below? Takashi --- diff --git a/i2c/other/Makefile b/i2c/other/Makefile index d5825f8..e67067f 100644 --- a/i2c/other/Makefile +++ b/i2c/other/Makefile @@ -5,17 +5,8 @@ endif include $(SND_TOPDIR)/toplevel.config include $(SND_TOPDIR)/Makefile.conf -export-objs += ak4xxx-adda.o ak4114.o ak4117.o pt2258.o - -# Toplevel Module Dependency -# hack for tea575x support -ifeq (y,$(CONFIG_VIDEO_DEV)) -obj-$(CONFIG_SND_FM801) += snd-tea575x-tuner.o -ifeq (m,$(CONFIG_SND_FM801)) -export-objs += tea575x-tuner.o +export-objs += ak4xxx-adda.o ak4114.o ak4117.o pt2258.o tea575x-tuner.o clean-files += tea575x-tuner.c -endif -endif include $(SND_TOPDIR)/alsa-kernel/i2c/other/Makefile