Re: [PATCH 2/2] ALSA sound driver for the AT73C213 DAC using Atmel SSC driver

[Takashi Iwai <tiwai@suse.de>]

At Mon, 16 Jul 2007 17:27:46 +0200,
Haavard Skinnemoen wrote:
> 
> On Mon, 16 Jul 2007 17:08:02 +0200
> Takashi Iwai <tiwai@suse.de> wrote:
> 
> > > +struct at73c213_board_info {
> > > +	int		ssc_id;
> > > +	struct clk	*dac_clk;
> > > +	char		shortname[32];
> > > +};
> > > +
> > > +#endif /* __LINUX_SPI_AT73C213_H */  
> > 
> > Any reason to put this into include/linux?  Are (or will be) there
> > users of this except for ALSA driver?
> 
> This struct contains information about how the sound chip is hooked up
> on the board, so it needs to be defined in a place where the platform
> code can easily find it. Since it's not arch specific, it doesn't
> belong under <asm/...> so <linux/spi/...> seems like a logical choice.
> 
> This patch shows how it's meant to be used:
> 
> http://avr32linux.org/archives/kernel/2007-July/000124.html

Fair enough, then I have no objection about that.


Takashi