From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: Request to change enums to int in alsa-lib Date: Wed, 10 May 2006 16:03:01 +0200 Message-ID: References: <4461E0C5.3040305@atmel.com> <4461EA69.1040108@atmel.com> <4461F1B7.5070401@atmel.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: <4461F1B7.5070401@atmel.com> Sender: alsa-devel-admin@lists.sourceforge.net Errors-To: alsa-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: To: Hans-Christian Egtvedt Cc: alsa-devel@lists.sourceforge.net List-Id: alsa-devel@alsa-project.org At Wed, 10 May 2006 15:59:19 +0200, Hans-Christian Egtvedt wrote: > > Takashi Iwai wrote: > > At Wed, 10 May 2006 15:28:09 +0200, > > Hans-Christian Egtvedt wrote: > >> Takashi Iwai wrote: > >>> At Wed, 10 May 2006 14:47:01 +0200, > >>> Hans-Christian Egtvedt wrote: > >> > >> > >>>> I have attached a patch which changes all enums into ints, and the > >>>> library now works for me. I have no idea if I have broken something > >>>> else. I have another issue, but I'll post that in a separate email. > >>> The change to include/sound/*.h looks OK. Actually, the kernel side > >>> was already fixed to use int. I was too lazy to update the alsa-lib > >>> side. > >>> > >>> But, are other changes really necessary? They are local in alsa-lib, > >>> so the size shouldn't matter. > >> I don't have the complete insight of which structs are being used > >> towards the kernel and which are just internal, so I did the "easy" way > >> of search and replace the entire library. If you, or somebody else with > >> good knowledge of the alsa library, redo my patch to those only used for > >> communication towards the kernel I can give it a go and see if it's > >> still good. > > > > The files in include/sound/* are kernel API. > > > > Some files in include/*.h are public (you can find in > > include/Makefile.am), so you should be careful to change them. > > Other files are internal in alsa-lib. > > > > So, just take a hunk to change include/sound/*.h from the original > > patch, and drop the rest. > > I've stripped the patch to do what you say now, and alsamixer and amixer > works fine. I have an issue with aplay and arecord, will post in another > email. Could you try to remove the change to include/local.h and include/mixer.h, too? At least, the latter is a public header, and I want to keep as it is unless it's completely broken. thanks, Takashi ------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642